Huge set of commits for 5.2 - #426
Merged
Merged
Conversation
- Update FtRandoLib reference - Make wasm output setting be local to browser project - Adjust margins changed in Avalonia 12
Sending the pasted text through the textbox makes it only possible to use the first line. I change it up to access the clipboard directly to make it work when the flags and seeds are on separate lines.
- The code now uses js65 and is being reloc'd instead of inserted at a magic PRG0 address. - HALF should now consistently trigger after 32 steps taken. (The high byte was previously not always reset). - Make RANDOM be random encounter rate per continent (The Random option previously did nothing and was just the same as normal.) - This will also make it possible to add other terrain to Maze Island without having MI encounters.
- Huge code cleanup - Shuffle the directions in which Maze Island is expanded - Position palace better inside grid
- Huge code cleanup - Add a check when opening up VoD entrances to prevent creating illegal entrances to any trap tiles - Add a check to stop rivers from opening up VoD center - Add slightly more variance to where the trap tiles are placed along the VoD zig-zag path
- Remove sword immunities when Fire is replaced by Dash or linked with Fairy - No sword immunities
Ellendar
approved these changes
Jul 17, 2026
Ellendar
left a comment
Ellendar
left a comment
Owner
There was a problem hiding this comment.
I have read through this monstrosity and everything looks sensible. There's some stuff I may want to adjust but at this point step 1 is get everything together and merged and then I can do testing/polishing so this is step 1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This contains a lot of refactorings and some improvements.
It's still an ongoing project to improve the overworld code readability and remove duplicate code for sure.
Please give feedback if there are some undesired changes or commits to remove.