Skip to content

tools: install lightning-downgrade, update its docs - #9747

Merged
sangbida merged 2 commits into
ElementsProject:masterfrom
ksedgwic:install-lightning-downgrade
Nov 19, 2026
Merged

sangbida merged 2 commits into
ElementsProject:masterfrom
ksedgwic:install-lightning-downgrade

Conversation

@ksedgwic

@ksedgwic ksedgwic commented Nov 18, 2026 •

Copy link
Copy Markdown
Collaborator

lightning-downgrade is built but make install does not install it, so the release archives contain its manual page and not the program. Fixes #9746.

The first commit adds the tool to BIN_PROGRAMS, next to lightning-hsmtool. Install, uninstall and the release archives (built with make install DESTDIR=...) follow from that list, and make installcheck passes with it. The second commit brings the VERSIONS section of the manual page up to v26.12 and names the tool in the upgrade guide.

One thing to confirm in review: I found no reason for the omission in #8702, its commits or the docs, so this PR treats it as an oversight. If the tool was left out of the install on purpose, the reason is worth recording and this PR should be closed.

lightning-downgrade is built with the other tools but is not in
BIN_PROGRAMS, so "make install" does not copy it to bindir.  The
release archives are made from that install, so they have the manual
page and not the program: a node upgraded from the release binaries
cannot go back without building the tool from source.

Add it to BIN_PROGRAMS, next to lightning-hsmtool.  Install and
uninstall both work from that list.

Changelog-Fixed: Tools: `lightning-downgrade` is now installed by `make install` and included in the release archives.
Fixes: ElementsProject#9746
@ksedgwic
ksedgwic requested review from nGoline and sangbida November 18, 2026 21:56
The VERSIONS section of lightning-downgrade(8) ended at v25.12.  Add
v26.04, v26.06 and v26.12.  Each goes back one release.  The v26.12
tool also removes askrene impressions from the stored layers, because
v26.06 cannot read them.

The upgrade guide said that downgrades are not generally possible and
did not mention the tool.  Name it there.

Changelog-None
@ksedgwic
ksedgwic force-pushed the install-lightning-downgrade branch from bccfa13 to 4fcd625 Compare November 18, 2026 22:08

@sangbida sangbida left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack 4fcd625

@sangbida sangbida added this to the v26.12 milestone Nov 19, 2026
@sangbida
sangbida merged commit 2e7a9f5 into ElementsProject:master Nov 19, 2026
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tools: lightning-downgrade is built but not installed, and not in the release archives

2 participants