Repository navigation
wallet: create bwatch tables before backfilling them - #9742
Merged
nGoline merged 1 commit intoNov 17, 2026
Merged
Conversation
Databases from v26.06.10 are at migration version 284 and never ran the our_outputs/our_txs CREATE TABLE migrations, which master placed at indices 283/284. On upgrade, migrate_backfill_bwatch_tables (index 285) then inserts into our_outputs and fails with "no such table". Create both tables with IF NOT EXISTS at the start of the backfill, so it works whether or not the earlier CREATEs ran. Existing databases already have the tables, so this is a no-op for them. Add a unit test that starts from a v26.06.10-shaped database without the bwatch tables.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Databases from v26.06.10 are at migration version 284 and never ran the our_outputs/our_txs CREATE TABLE migrations, which master placed at indices 283/284. On upgrade, migrate_backfill_bwatch_tables (index 285) then inserts into our_outputs and fails with "no such table".
Create both tables with IF NOT EXISTS at the start of the backfill, so it works whether or not the earlier CREATEs ran. Existing databases already have the tables, so this is a no-op for them.
Add a unit test that starts from a v26.06.10-shaped database without the bwatch tables.
Fixes: #9608
Changelog-None