Repository navigation
Conversation
Andezion
reviewed
Nov 5, 2026
nepet
force-pushed
the
plugins/lsps2/fix-wrong-unknown-next-peer
branch
from
November 10, 2026 15:44
9156187 to
edec3d3
Compare
Andezion
previously approved these changes
Nov 13, 2026
Andezion
left a comment
Collaborator
There was a problem hiding this comment.
do you want to add a test?
#[test]
fn failure_codes_match_bolt4() {
assert_eq!(UNKNOWN_NEXT_PEER, format!("{:04x}", 0x4000 | 10));
assert_eq!(TEMPORARY_CHANNEL_FAILURE, format!("{:04x}{:04x}", 0x1000 | 7, 0));
}
nepet
force-pushed
the
plugins/lsps2/fix-wrong-unknown-next-peer
branch
from
November 16, 2026 16:40
c6e1f89 to
d453428
Compare
Fixes the type for UNKNOWN_NEXT_PEER Changelog-Fixed: correct unknown next peer error type for the lsp service
…_failure temporary_channel_failure (UPDATE|7) carries a u16 len followed by a channel_update. We returned only the 2-byte type "1007", which is a truncated message the payer can't parse. Append an empty length field, matching towire_temporary_channel_failure(ctx, NULL). Changelog-Fixed: lsps2 service: temporary_channel_failure onion error is no longer truncated.
The service sends unknown_next_peer (PERM|10) and temporary_channel_failure (UPDATE|7 plus an empty channel_update length) as hex strings. Build the expected values from the BOLT 4 flags, so a wrong hex literal gets caught. Changelog-None
nepet
force-pushed
the
plugins/lsps2/fix-wrong-unknown-next-peer
branch
from
November 17, 2026 09:31
d453428 to
ed145c5
Compare
Andezion
approved these changes
Nov 17, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the type for UNKNOWN_NEXT_PEER
Changelog-Fixed: correct unknown next peer error type for the lsp service
Important
26.09 FREEZE August 5th: Non-bugfix PRs not ready by this date will wait for 26.12.
RC1 is scheduled on August 17th
The final release is scheduled for September 7th.
Checklist
Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked:
tools/lightning-downgradeFixes a wrong onion failure type on the lsp-service