Skip to content

ci: bind version/ref inputs via env before shell in release workflows #9388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SashaMIT wants to merge 2 commits into
base: master
Choose a base branch
from
+25 −11
Open

ci: bind version/ref inputs via env before shell in release workflows #9388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eeca731
ci: bind version/ref inputs via env before shell in release workflows
SashaMIT Aug 6, 2026
dffc947
ci: bind GPG keyid via env before shell in release-publish
SashaMIT Aug 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions .github/workflows/check-release-tag.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,14 @@ jobs:

- name: Validate tag matches .version file
id: resolve
env:
REF_TYPE: ${{ github.ref_type }}
INPUT_VERSION: ${{ inputs.version }}
REF_NAME: ${{ github.ref_name }}
run: |
if [[ "${{ github.ref_type }}" != "tag" ]]; then
echo "::notice::Not triggered by a tag push (ref_type=${{ github.ref_type }}); skipping .version check."
echo "version=${{ inputs.version }}" >> "$GITHUB_OUTPUT"
if [[ "$REF_TYPE" != "tag" ]]; then
echo "::notice::Not triggered by a tag push (ref_type=$REF_TYPE); skipping .version check."
echo "version=$INPUT_VERSION" >> "$GITHUB_OUTPUT"
exit 0
fi

Expand All @@ -41,7 +45,7 @@ jobs:
fi

FILE_VERSION="$(tr -d '[:space:]' < .version)"
TAG_VERSION="${{ github.ref_name }}"
TAG_VERSION="$REF_NAME"

if [[ "$TAG_VERSION" != "$FILE_VERSION" ]]; then
echo "::error::Tag '$TAG_VERSION' does not match version in .version file ('$FILE_VERSION'). Refusing to release."
Expand All @@ -53,4 +57,6 @@ jobs:

- name: Validate release
if: ${{ !inputs.skip_validation }}
run: tools/check-release.sh --version=${{ steps.resolve.outputs.version }}
env:
RESOLVED_VERSION: ${{ steps.resolve.outputs.version }}
run: tools/check-release.sh "--version=$RESOLVED_VERSION"
4 changes: 3 additions & 1 deletion .github/workflows/pypi-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,10 @@ jobs:
uses: astral-sh/setup-uv@v8.1.0

- name: Update pyln versions
env:
INPUT_VERSION: ${{ inputs.version }}
run: |
make update-pyln-versions NEW_VERSION=${{ inputs.version }}
make update-pyln-versions NEW_VERSION="$INPUT_VERSION"

- name: Build distribution 📦
run: uv build --package ${{ matrix.PACKAGE }}
Expand Down
7 changes: 5 additions & 2 deletions .github/workflows/release-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,12 @@ jobs:
if: contains(matrix.target, 'Ubuntu')

- name: Build release
env:
SKIP_VALIDATION: ${{ inputs.skip_validation }}
INPUT_VERSION: ${{ inputs.version }}
run: |
if [[ "${{ inputs.skip_validation }}" == "true" ]]; then
tools/build-release.sh ${{ matrix.target }} --force-version "${{ inputs.version }}" --force-unclean --force-mtime "$(date +%Y-%m-%d)"
if [[ "$SKIP_VALIDATION" == "true" ]]; then
tools/build-release.sh ${{ matrix.target }} --force-version "$INPUT_VERSION" --force-unclean --force-mtime "$(date +%Y-%m-%d)"
else
tools/build-release.sh ${{ matrix.target }}
fi
Expand Down
9 changes: 6 additions & 3 deletions .github/workflows/release-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,9 @@ jobs:
trust_level: 5

- name: Set default GPG key
run: echo "default-key ${{ steps.gpg.outputs.keyid }}" >> ~/.gnupg/gpg.conf
env:
GPG_KEYID: ${{ steps.gpg.outputs.keyid }}
run: echo "default-key $GPG_KEYID" >> ~/.gnupg/gpg.conf

- name: Sign release
run: tools/build-release.sh --without-zip sign
Expand All @@ -49,9 +51,10 @@ jobs:

- name: Determine release data
id: release_data
env:
INPUT_VERSION: ${{ inputs.version }}
run: |
CHANGELOG_VERSION=${VERSION#v}

@Andezion Andezion Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

VERSION="${{ inputs.version }}"
VERSION="$INPUT_VERSION"
CHANGELOG_VERSION=${VERSION#v}
CHANGELOG_TITLE=$(grep "## \[${CHANGELOG_VERSION}\]" CHANGELOG.md)
RELEASE_TITLE=$(echo $CHANGELOG_TITLE | cut -d'"' -f2)
Expand Down
Loading