You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
xpay treatment of onion errors is incomplete #9738
It was mentioned in #9681
that disabling a node that returns INVALID_ONION_VERSION, INVALID_ONION_KEY and INVALID_ONION_HMAC
is the correct approach under the assumption that the erring node has a problem.
But it might well be that the previous node is the one providing the invalid onion to its peer.
A more thoughtful response could be to record the pair of nodes (A, B), where B is the one reporting and A is it's ancestor,
then disable all channels connecting A->B, and try again. If we see again node B failing with those errors but for a different
ancestor A', it is likely that B has an issue. Otherwise if we see another node B' having those errors with the same ancestor A
then it is likely that A has an issue.
Also the default behavior in xpay is to disable a channel between nodes (A,B) when a weird error is reported. We might as well
disable every other parallel channel, since the same error is likely to persist between this pair.
Activity