Conversation
After stripping vision-tower tensors, the script removed the dropped keys from model.safetensors.index.json but left metadata.total_size at its pre-strip value, so the index reported more bytes than the shards actually contain. Accumulate the dropped tensor bytes across shards and subtract them from metadata.total_size when the field is present. Add a stdlib-only regression test that builds a synthetic shard + index, runs the script, and checks the corrected total_size. Fixes Edge0-AI#18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After stripping vision-tower tensors, the script removed the dropped
keys from model.safetensors.index.json but left metadata.total_size at
its pre-strip value, so the index reported more bytes than the shards
actually contain.
Accumulate the dropped tensor bytes across shards and subtract them
from metadata.total_size when the field is present.
Add a stdlib-only regression test that builds a synthetic shard +
index, runs the script, and checks the corrected total_size.
Fixes #18