docs(streaming): correct load_hot_layer's "page cache" backing claim - #118
Open
agourakis82 wants to merge 1 commit into
Open
agourakis82 wants to merge 1 commit into
agourakis82 wants to merge 1 commit into
Conversation
load_hot_layer()'s docstring described the hot-expert backing store as "page cache" that "survives across requests, counts ZERO toward MLX active" -- true of the zero-MLX-cost and survives-across-requests parts, but the backing is built with np.concatenate(rows), which copies. That makes it resident anonymous process memory, not mmap'd/file-backed page cache: it is not reclaimable by the OS the way page cache is, and does not shrink under memory pressure the way the docstring's "page cache" framing implies. Fixes the misleading description and the matching inline comment further down the same method. No behavior change. Addresses point 2 of Edge0-AI#106 (the README wording in points 1 and 3 was already addressed in the issue thread by the maintainer). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses point 2 of #106 (the README-wording points 1 and 3 were already addressed by the maintainer directly in the issue thread, so this PR is scoped to the uncontested code-doc inaccuracy only).
load_hot_layer()'s docstring described the hot-expert backing store as "page cache" that "survives across requests, counts ZERO toward MLX active." The survives-across-requests and zero-MLX-cost parts are correct, but the backing is built withnp.concatenate(rows), which copies — so it's resident anonymous process memory, not mmap'd/file-backed page cache. Unlike page cache, the OS can't reclaim it under memory pressure.Fix
Corrects the docstring and the matching inline comment further down the same method. No behavior change — documentation only.
Test plan
pytest -m 'not slow': 79 passed, 1 skipped (no regressions, as expected for a docs-only change).