fix(scripts): upload README.md in upload_hf.py - #116
Open
agourakis82 wants to merge 1 commit into
Open
agourakis82 wants to merge 1 commit into
agourakis82 wants to merge 1 commit into
Conversation
The upload-file listing explicitly excluded README.md ("README usually
already uploaded; skip leftovers handled below"), but nothing below
handled leftovers -- the README is simply never uploaded. Given a
checkpoint directory of README.md, config.json, and model.safetensors,
only config.json and model.safetensors were recorded as uploaded.
Removes the exclusion and extracts the listing into files_to_upload()
so the file-selection rule (dotfiles and .bak_vision backups excluded,
everything else included) is independently testable without touching
the network.
Fixes Edge0-AI#103.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #103.
upload_hf.py's file listing explicitly excludedREADME.mdwith the comment "README usually already uploaded; skip leftovers handled below" — but nothing below handled leftovers, so the README was simply never uploaded. Given a checkpoint dir ofREADME.md,config.json,model.safetensors, only the last two were recorded as uploaded.Fix
Removed the exclusion and extracted the file-selection logic into
files_to_upload()so the rule (skip dotfiles and.bak_visionbackups, upload everything else) is independently unit-testable without touching the network.Test plan
tests/test_upload_hf.py:files_to_upload()includes README.md, excludes dotfiles and.bak_visionbackups.pytest -m 'not slow': 81 passed, 1 skipped (no regressions).