Conversation
Adds functionality so the player can actually find tracker module files(.mod, .xm, .s3m and .it) for Music and Sound.
| ".opus", ".oga", ".ogg", ".wav", ".mid", ".midi", ".mp3", ".wma", ".mod", ".xm", ".s3m", ".it"); | ||
| constexpr const auto SOUND_TYPES = Utils::MakeSvArray( | ||
| ".opus", ".oga", ".ogg", ".wav", ".mp3", ".wma"); | ||
| ".opus", ".oga", ".ogg", ".wav", ".mp3", ".wma", ".mod", ".xm", ".s3m", ".it"); |
There was a problem hiding this comment.
IMO these should be music-only.
There was a problem hiding this comment.
I would initially think so too, but they work fine from my testing as using these formats as Sound Effects... Even when played with a BGM Track at the same time!
There was a problem hiding this comment.
This is abused too much in certain games but sound effects should be something short and not entire music tracks (they are converted to uncompressed samples and cached for performance reasons).
Also doesn't tracker music support built in loops? Pretty sure this will softlock the sound decoder.
So I'm kinda against usage in sound effects but maybe you can convince me.
There was a problem hiding this comment.
What makes Tracker modules only use case being music tracks? What's stopping someone from using a super short, one-shot module for a sound effect? Likewise, what's stopping someone from trying to pass off a very long WAV or OGG sound effect?
yeah they do, they have jump commands, maybe the sound decoder should ignore jump(loop) commands in sound effects if your worried developers are going to add loops in their tracker modules used for sounds...
Isn't this a developer best practice issue though? don't use large multi-second long tracks for sound effects and do not loop sound effect tracks?
The reason why I said 'Even when played with a BGM Track at the same time!', is because back in the day, sound effects were injected via code to hijack a channel(like one of the 4 channels on the Amiga, not unlike the home and handheld consoles at the time) rather than stand-alone modules, but we don't have those limits anymore... especially not limited on Audio Channels like the old computers and consoles from back in the day.
Anyway, you can remove it from the Sound_Types if you want, it most certainly won't be a huge issue if the formats aren't supported sound effect types and if I have to be honest, I am still learning the format anyways...
There was a problem hiding this comment.
I will test a bit if i can find any problems in terms of using them as sounds and report back.
|
superseded by #3690 |
3 participants
Adds functionality so the player can actually find tracker module files(.mod, .xm, .s3m and .it) for Music and Sound.