Repository navigation
1.0.0 build 32: switching language/mode/width no longer eats the code - #212
Merged
Merged
Conversation
The third "HUD did not appear" turned out not to be a defect: after the file-based switch and branch logging shipped in build 31, the user retested and both the HUD and the candidate window behaved normally — the earlier symptom came from a host process still running the previous binary after a package swap. Adds the check that catches this to the iterate-macos-ime closing list (lsof must not report a deleted executable for the running host), records the build-31 baseline on both machines, and notes why 30 was replaced. Signed-off-by: wangzhizhou <824219521@qq.com>
Typing nihao and pressing Shift used to delete the code and the candidate window, because toggle_english, toggle_width and set_mode all called cancel() in the core, while the variant and punctuation switches only wrote configuration and kept the composition. Shift now commits the raw code (nihao stays nihao) before switching to English, which matches why people press it; mode and width switches keep the buffer, and mode re-converts under the new setting without auto committing. Escape still cancels a buffer that has no candidates. Three core tests cover it; the FFI source-code test now escapes before changing mode instead of relying on the removed cancel. Build 32. Signed-off-by: wangzhizhou <824219521@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
按用户报告的行为做的一批输入连续性改进（ADR-302，报告 221）。
问题
编码已出现候选框时，按 Shift / ⌥M / ⌥F 会立刻把编码和候选窗一起清掉，而 ⌥T/⌥P 是在候选窗内联反馈。根因：前三个在
ime-core里主动cancel()。判断
改法
nihao→nihao），再切英文（宿主用已有insertText，无 ABI 变更）recompute_with_commit(false)重算候选，不自动上屏；无候选也保留编码验证
ime-ffi的candidates_expose_source_codes改为先 Esc 再切模式（旧用例依赖了被删除的取消语义）make verifyPASS；make macos-offline-tests56 文件 / 303 例 PASS装机后请复验
打字出候选 → 按 Shift（编码应原样上屏为
nihao）→ 再按 ⌥M / ⌥F（候选框与编码应保留）。