fix: 7787 - #7790
Open
KDederichs wants to merge 1 commit into
Open
Conversation
KDederichs
force-pushed
the
fix/7787
branch
2 times, most recently
from
August 15, 2026 20:12
a4cff58 to
d63cee6
Compare
Contributor
Author
|
Failing tests are related to the doctrine bridge being incompatible with the orm version. |
Seb33300
reviewed
Aug 16, 2026
Comment on lines
+52
to
+54
| if (\count($choices) >= 1 && null === $enumTypeClass && $allChoicesAreEnums) { | ||
| $enumTypeClass = \get_class($choices[array_key_first($choices)]); | ||
| } |
Contributor
There was a problem hiding this comment.
I think the relation should be resolved using resolveNestedAssociations so it can return the proper enum type
Contributor
Author
There was a problem hiding this comment.
Is there ever a case where the enum type you map to it is different from the actual enum you have in there?
I can't think of any case where that would make sense and not lead to errors blowing up the entity cause the enum can not be parsed.
Contributor
Author
|
Meh I just noticed setting the enum class actually breaks rendering of choice values when you explicitly map the names ['Foo' => Bar::Foo] I'll need to look at that eventually. |
KDederichs
marked this pull request as draft
August 21, 2026 08:31
… that all choices are Enums, just grab the first one and get its class Fixes EasyCorp#7787
KDederichs
marked this pull request as ready for review
August 22, 2026 06:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if enum class could not be resolved but it's already established that all choices are Enums, just grab the first one and get its class
Edit: targeting 4.x since it's a bugfix imo
Fixes #7787