Improve enum type class retrieval logic - #7785
Open
Seb33300 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a case where I am fetching a non mapped field returning enum.
Because the field is not mapped, enum type can't be retrieved from doctrine.
In that case I have explicitly specified the
classoption of the form type using->setFormTypeOption('class', Role::class).But unfortunately, this option is not supported at the moment. This PR fixes that issue.
I have a case where a non-mapped field returns an enum.
Because the field is not mapped, its enum type cannot be retrieved from Doctrine metadata. In this case, I explicitly specify the class option of the form type using:
However, this option is currently not taken into account when determining the enum type.
This PR fixes the issue by also using the form type's class option to determine the enum type, falling back to Doctrine metadata when necessary.