Auto-generate initial conditions and improve grid-input staging#17
Open
alperaltuntas wants to merge 3 commits into
Open
Auto-generate initial conditions and improve grid-input staging#17alperaltuntas wants to merge 3 commits into
alperaltuntas wants to merge 3 commits into
Conversation
buildnml: Guard against a missing/empty WW3_GRID_INP_DIR, and warn (instead of crashing) when ww3_grid.inp or the ww3_grid executable aren't present yet before attempting mod_def generation. namelist_definition_ww3.xml: Add six individual grid input file entries (g37_mapsta.inp, g37_bottom.inp, g37_y.inp, g37_x.inp, ww3_grid.inp, ww3_strt.inp) for the wgx3v7 grid so check_input_data can download them automatically.
Generate the calm-start initial condition file at build time via the
ww3_strt tool instead of pre-staging per-grid restart files. buildnml
now copies the ww3_strt executable alongside ww3_grid, runs it to
produce restart.ww3, and stages it to rundir as calm_strt.ww3. The
initfile namelist default points to calm_strt.ww3 for auto-generated
grids; supplying a custom WW3_MODDEF now requires an explicit initfile.
Also:
- Add domain_percent_iostyp (DOMAIN%IOSTYP) namelist entry, default 1
- Add grid input files (mapsta/bottom/x/y/grid/strt) for ww3a and
wtx2_3v2 grids
- Bump grid_inp data for wgx3v7 to .260527. This is to update IC4METHOD
from 8 to 10.
- Updates in tests.
Member
Author
|
@mvertens Please let us know if you'd like review this PR and/or ESCOMP/WW3#39. |
Collaborator
|
@alperaltuntas - sorry for my slow response to this. Thanks for this update. Can we chat about this? I'd like to bring these changes back to NorESMHub and coordinate this with what you have done. |
Member
|
@alperaltuntas - thank you for calling this to my attention. Are there particular aspects you'd like my review on? If not, I'm happy to defer to you and others with more familiarity with ww3 operation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generate WW3 initial conditions at build time via
ww3_strtinstead ofpre-staging per-grid restart files, and harden grid-input staging.
Changes
calm_strt.ww3) viaww3_strt; auser-supplied
WW3_MODDEFnow requires an explicitinitfile.buildnmlagainst missingWW3_GRID_INP_DIR/inputs, warninginstead of crashing and deferring generation past the build phase.
wgx3v7,ww3a, andwtx2_3v2.domain_percent_iostypnamelist entry (default 1).wgx3v7grid_inp data and the WW3 submodule (always buildww3_strt; IOSTYP restart-gather deadlock fix).This PR is in conjunction with ESCOMP/WW3#39
Fixes: #16
Testing: aux_ww3. all b4b.