Fix _read_mom input err msg - #350
Open
alperaltuntas wants to merge 1 commit into
Open
alperaltuntas wants to merge 1 commit into
alperaltuntas wants to merge 1 commit into
Conversation
_read_MOM_input prints out an error message if a variable is specified more than once. The error message includes the input_path which was previously a string, but now is a Path object. So, we need to cast it.
mnlevy1981
reviewed
Sep 22, 2026
mnlevy1981
left a comment
mnlevy1981
left a comment
Collaborator
There was a problem hiding this comment.
Is there a reason to use the + operator instead of just an f-string, though?
raise SystemExit(f"ERROR: {varname} listed more than once in {input_path}")should work with both strings and Path objects
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_read_MOM_inputprints out an error message if a variable is specified more than once. The error message includes theinput_pathwhich was previously a string, but now is a Path object. So, we need to cast it string.