Skip to content

Stabilize prek CI by pinning Rust toolchain resolution#738

Merged
kvinwang merged 2 commits into
masterfrom
copilot/fix-prek-github-actions-job
Jun 23, 2026
Merged

Stabilize prek CI by pinning Rust toolchain resolution#738
kvinwang merged 2 commits into
masterfrom
copilot/fix-prek-github-actions-job

Conversation

Copilot AI commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

The prek GitHub Actions job was failing in the cargo fmt hook due to rustup attempting a partial toolchain recovery and hitting a cargo-clippy component conflict. This updates the workflow so prek hooks run against the explicitly pinned Rust toolchain.

  • Problem

    • prek run invoked cargo fmt, which resolved through implicit rustup/toolchain behavior and triggered:
      • failed to install component ... clippy-preview ... detected conflict: 'bin/cargo-clippy'
  • Change

    • Set a job-level Rust toolchain override in .github/workflows/prek-check.yml:
      • RUSTUP_TOOLCHAIN: 1.92.0
    • This ensures cargo fmt in prek runs against the preinstalled pinned toolchain instead of re-resolving via rustup during hook execution.
  • Effect

    • Removes nondeterministic rustup component reconciliation from the prek path.
    • Keeps formatting checks aligned with the intended pinned Rust version.
jobs:
  prek:
    runs-on: ubuntu-latest
    env:
      RUSTUP_TOOLCHAIN: 1.92.0

Copilot AI changed the title [WIP] Fix failing GitHub Actions job 'prek' Stabilize prek CI by pinning Rust toolchain resolution Jun 23, 2026
Copilot AI requested a review from kvinwang June 23, 2026 02:25
@kvinwang kvinwang marked this pull request as ready for review June 23, 2026 03:00
Copilot AI review requested due to automatic review settings June 23, 2026 03:00
@kvinwang kvinwang merged commit 1b92f89 into master Jun 23, 2026
16 checks passed

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR stabilizes the prek GitHub Actions workflow by forcing prek-invoked Rust tooling (notably cargo fmt) to run under an explicitly pinned Rust toolchain, avoiding rustup component conflict/recovery behavior during hook execution.

Changes:

  • Add a job-level RUSTUP_TOOLCHAIN: 1.92.0 environment override for the prek job.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants