Sweep camera into and out of 3D battles - #8
Open
kennethreitz wants to merge 1 commit into
Open
Conversation
kennethreitz
marked this pull request as ready for review
July 29, 2026 11:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
What changed
The 3D battle path now captures the exact active overworld camera, interpolates its eye, focus, field of view, and world curvature into the battle camera, and reverses that move before returning control to the player.
Entry and exit are explicit battle phases. Battle logic, furniture, and UI remain out of the way during the camera move, while the existing Pokémon composition remains intact for the exit. Destructive battle teardown is delayed until the return sweep completes.
The transition is presentation-only: it does not move the player, Pokémon, or arena. Any rendering failure resumes the plain battle path or tears down immediately rather than leaving the game stuck.
This bumps the mod version to 1.1.3.
Why
The 3D battle environment already makes battles feel continuous with the voxel overworld, but an immediate camera cut made entering and leaving them feel disconnected. A short sweep preserves that spatial relationship without slowing normal play.
Validation
lua tests/battle_sweep_test.lua