node Global view & account history by GuillaumeDSM · Pull Request #3642 · Drakkar-Software/OctoBot

GuillaumeDSM · 2026-08-11T09:47:13Z

requires Drakkar-Software/ccxt#29
includes:

global view update via scheduled job (ev. 5min)
account history fetch & sync (stored in optimized sqlite) via daily scheduled job
reduce tasks.db growing size by a lot

Herklos · 2026-08-26T06:33:01Z

+
+    async def fetch_deposits(self, since: int = None, limit: int = None) -> list[dict]:
+        try:
+            return await self.exchange_manager.exchange.get_deposits(since=since, limit=limit)


Could it make sense to create an updater the same way as trades and others and to use the updater here instead of the exchange manager function?

good point, it's not used but it would fit the architecture, i'll add an updater that for now will only be used there

Herklos

Awesome testing framework! Great job

Herklos

Great job! And very nice testing work 💯

Herklos · 2026-08-30T19:19:48Z

+            await self.inner_test_get_my_recent_trades_exhaust_history()
+
+    @expect_not_supported_on_read_only("get_my_recent_trades")
+    async def inner_test_get_my_recent_trades_exhaust_history(self):


Herklos · 2026-08-30T19:19:57Z

+            await self.inner_test_get_deposits()
+
+    @expect_not_supported_on_read_only("get_deposits")
+    async def inner_test_get_deposits(self):


Herklos · 2026-08-30T19:28:57Z

+            response = tenant_client.get("/api/v1/accounts/acc-1/historical-values")
+        assert response.status_code == 503
+
+    def test_returns_401_without_auth(self, client, mock_auth):


Herklos · 2026-08-30T19:29:52Z

+import octobot_sync.sync.collection_backend.single_item_local_collection_provider as single_item_provider
+
+
+class AccountHistoryProvider(


Herklos · 2026-08-30T19:30:40Z

@@ -818,6 +837,45 @@
          }
        }
      },
+      "TransactionType": {


Herklos · 2026-08-30T19:30:58Z

+          }
+        }
+      },
+      "ResetAccountTradingDataConfiguration": {


Herklos · 2026-08-30T19:34:38Z

+def _parse_base_quote(symbol: str) -> tuple[str, str] | None:
+    if "/" not in symbol:
+        return None
+    base_asset, quote = symbol.split("/", 1)
+    if not base_asset or not quote or base_asset == quote:
+        return None
+    return base_asset, quote


Shouldn't we use commons Symbol instead ?

Herklos · 2026-08-30T19:47:34Z

+    return sorted(symbol for symbol in symbols if symbol in live_symbols)
+
+
+def _derive_price_symbols(


Shouldn't we use commons.Symbol ?

Herklos · 2026-08-30T19:52:48Z

+        )
+        # Update persisted latest-tickers cache from fetched ticker closes.
+        if exchange_refresh_result.ticker_closes:
+            await trading_api.update_latest_tickers(


Herklos

👍

Herklos · 2026-08-30T19:55:07Z

+    return replicable
+
+
+def is_order_impossible_at_market_price(


Herklos · 2026-08-30T19:56:05Z

+
+
+class TestPatchTaskContentDegradedState:
+    def test_persists_degraded_state_in_task_content(self):


Herklos · 2026-08-30T19:57:07Z

+SCHEMA_VERSION = 1
+
+
+class MarketDataSQLiteDatabase(base_sqlite_database.BaseSQLiteDatabase):


Herklos · 2026-08-30T19:58:18Z

+        assert result[day_1_start]["USDT"][TOTAL] == decimal.Decimal("0")
+
+
+class TestBuildHistoricalHoldingsDepositWithdrawal:


GuillaumeDSM self-assigned this Aug 11, 2026

GuillaumeDSM force-pushed the global_view branch 14 times, most recently from fba8b81 to 122c190 Compare August 17, 2026 21:14

GuillaumeDSM force-pushed the global_view branch 9 times, most recently from 588cf6f to 23c772b Compare August 25, 2026 12:00

GuillaumeDSM changed the title ~~WIP node Global view~~ node Global view & account history Aug 25, 2026

GuillaumeDSM force-pushed the global_view branch 3 times, most recently from 396e50a to d689807 Compare August 25, 2026 20:42

Herklos reviewed Aug 26, 2026

View reviewed changes

GuillaumeDSM force-pushed the global_view branch from d689807 to 86027ca Compare August 28, 2026 09:08

GuillaumeDSM added 6 commits August 28, 2026 11:18

[Node] add global view account refresher

feda7b1

[Node] fix tests & reduce logs

adcbc6c

[Copy] handle outdated orders signals

b793660

[Portfolio] compute portfolio history from trades and transactions

21d3f3b

[Tentacles] fix process decoding error

92c58f9

[Exchanges] support transactions fetch

782627a

GuillaumeDSM force-pushed the global_view branch 4 times, most recently from a559618 to 618b246 Compare August 28, 2026 14:25

CI fixees

57a0085

GuillaumeDSM force-pushed the global_view branch from 618b246 to 57a0085 Compare August 28, 2026 14:58

GuillaumeDSM added 2 commits August 29, 2026 14:10

[Backtesting] improve tests and use readonly

5cb036a

[Automation] reduce stored data size

4003808

GuillaumeDSM force-pushed the global_view branch from 46572d4 to f36e8db Compare August 29, 2026 14:20

GuillaumeDSM marked this pull request as ready for review August 29, 2026 14:31

[Node] fix unwanted automation stop

2021eff

GuillaumeDSM force-pushed the global_view branch from f36e8db to 2021eff Compare August 29, 2026 21:20

Herklos reviewed Aug 30, 2026

View reviewed changes

		import octobot_sync.sync.collection_backend.single_item_local_collection_provider as single_item_provider


		class AccountHistoryProvider(

		return sorted(symbol for symbol in symbols if symbol in live_symbols)


		def _derive_price_symbols(



		class TestPatchTaskContentDegradedState:
		def test_persists_degraded_state_in_task_content(self):

		SCHEMA_VERSION = 1


		class MarketDataSQLiteDatabase(base_sqlite_database.BaseSQLiteDatabase):

		assert result[day_1_start]["USDT"][TOTAL] == decimal.Decimal("0")


		class TestBuildHistoricalHoldingsDepositWithdrawal:

Uh oh!

Uh oh!

Conversation

GuillaumeDSM commented Aug 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Herklos left a comment

Choose a reason for hiding this comment

Uh oh!

Herklos left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Herklos left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

GuillaumeDSM commented Aug 11, 2026 •

edited

Loading