add combobox#1389
Conversation
…istered on gateway
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (15)
WalkthroughThis PR adds a "combobox" variant for string/number scalar fields (schema, translation logic, and a playground example), introduces a ChangesCombobox Variant and Summary Actions
Estimated code review effort: 2 (Simple) | ~15 minutes Sequence Diagram(s)sequenceDiagram
participant Root
participant InstrumentRenderer
participant ScalarInstrumentRenderer
participant InstrumentSummary
Root->>InstrumentRenderer: render with disableSummaryActions=true
InstrumentRenderer->>ScalarInstrumentRenderer: pass disableSummaryActions
ScalarInstrumentRenderer->>InstrumentSummary: pass disableActions
alt disableActions is true
InstrumentSummary-->>InstrumentSummary: skip rendering copy/download/print toolbar
else disableActions is false
InstrumentSummary-->>InstrumentSummary: render toolbar
end
Possibly related PRs
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary by CodeRabbit
New Features
Bug Fixes
Chores