Skip to content

🔒 fix(service): secure Appium service TLS verification #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dor-bl wants to merge 1 commit into
base: master
Choose a base branch
from
Open

🔒 fix(service): secure Appium service TLS verification #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion appium/webdriver/appium_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,12 @@

from selenium.webdriver.remote.remote_connection import urllib3

try:
import certifi

_ca_certs: str | None = certifi.where()
except ImportError:
_ca_certs = None
DEFAULT_HOST = '127.0.0.1'
DEFAULT_PORT = 4723
STARTUP_TIMEOUT_MS = 60000
Expand Down Expand Up @@ -208,7 +214,10 @@ def is_service_listening(url: str, timeout: float = 5, custom_validator: Callabl
True if Appium server is running before the timeout
"""
time_started_sec = time.perf_counter()
conn = urllib3.PoolManager(timeout=1.0)
pool_kwargs: dict[str, Any] = {'timeout': 1.0, 'cert_reqs': 'CERT_REQUIRED'}
if _ca_certs:
pool_kwargs['ca_certs'] = _ca_certs
conn = urllib3.PoolManager(**pool_kwargs)
while time.perf_counter() < time_started_sec + timeout:
if custom_validator is not None:
custom_validator()
Expand Down
Loading