Skip to content

⚡ perf: optimize direct connect capabilities extraction #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dor-bl wants to merge 1 commit into
base: master
Choose a base branch
from
Open

⚡ perf: optimize direct connect capabilities extraction #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions appium/webdriver/webdriver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,10 +304,14 @@ def _update_command_executor(self, keep_alive: bool) -> None:

if not self.caps:
raise ValueError('Driver capabilities must be defined')
if not {direct_protocol, direct_host, direct_port, direct_path}.issubset(set(self.caps)):
message = 'Direct connect capabilities from server were:\n'
for key in [direct_protocol, direct_host, direct_port, direct_path]:
message += f"{key}: '{self.caps.get(key, '')}' "
if not {direct_protocol, direct_host, direct_port, direct_path}.issubset(self.caps):
message = (
f'Direct connect capabilities from server were:\n'
f"{direct_protocol}: '{self.caps.get(direct_protocol, '')}' "
f"{direct_host}: '{self.caps.get(direct_host, '')}' "
f"{direct_port}: '{self.caps.get(direct_port, '')}' "
f"{direct_path}: '{self.caps.get(direct_path, '')}' "
)
logger.debug(message)
return

Expand Down
Loading