Repository navigation
ci: reduce iOS functional test flakiness #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Dor-bl
wants to merge
11
commits into
master
Choose a base branch
from
ccr-08794045-91mrk3-ios
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
8b2f617
ci: reduce iOS functional test flakiness
claude efc258a
ci: remove stray blank line
claude d0ba8a9
test: retry iOS session creation when WDA fails to start
claude 2a56e4c
ci: quote python-version values in functional tests workflow
claude 20557b4
ci: pin uv in Android job and use read-only token permissions
claude 0822e5b
ci: warm up WebDriverAgent with a throwaway Appium session
claude 5627629
ci: don't let a failed WDA warm-up skip the tests
claude a1673ab
Merge remote-tracking branch 'origin/master' into ccr-08794045-91mrk3…
claude d188bdf
test: keep per-test Safari sessions and give the WDA warm-up the full…
claude 3c9ef0b
test: keep the WDA warm-up non-fatal when quitting the session fails
claude ab37714
test: make the WDA warm-up a single attempt so it fits its step timeout
claude File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| #!/usr/bin/env python | ||
|
Dor-bl marked this conversation as resolved.
Resolved
Dor-bl marked this conversation as resolved.
Resolved
|
||
|
|
||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| """Start and quit one Appium session so WebDriverAgent's first, slowest launch happens before the tests. | ||
|
|
||
| Used by CI only. Failures are reported but don't fail the step: the tests retry on their own. | ||
| It makes a single attempt, so that it always finishes within the step's 12-minute timeout. | ||
| """ | ||
|
|
||
| import sys | ||
|
|
||
| from appium import webdriver | ||
| from appium.webdriver.client_config import AppiumClientConfig | ||
| from test.helpers.constants import SERVER_URL_BASE | ||
|
|
||
| from .options import make_options | ||
|
|
||
|
|
||
| def main() -> int: | ||
| client_config = AppiumClientConfig(remote_server_addr=SERVER_URL_BASE) | ||
| # Match the tests' timeout: giving up earlier would leave the server still creating this | ||
| # session, so the first test's session request would queue behind it. | ||
| client_config.timeout = 600 | ||
| try: | ||
| driver = webdriver.Remote(options=make_options(), client_config=client_config) | ||
| except Exception as e: # noqa: BLE001 | ||
| print(f'Warm-up session failed: {e}', file=sys.stderr) | ||
| return 0 | ||
| try: | ||
| driver.quit() | ||
| except Exception as e: # noqa: BLE001 | ||
| print(f'Warm-up session started but failed to quit: {e}', file=sys.stderr) | ||
| return 0 | ||
|
Dor-bl marked this conversation as resolved.
Resolved
Dor-bl marked this conversation as resolved.
Resolved
|
||
| print('Warm-up session started and quit successfully') | ||
| return 0 | ||
|
|
||
|
|
||
| if __name__ == '__main__': | ||
| sys.exit(main()) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.