fix(webdriver): normalize orientation value to uppercase in setter - #15
Open
Dor-bl wants to merge 1 commit into
Open
fix(webdriver): normalize orientation value to uppercase in setter#15Dor-bl wants to merge 1 commit into
Dor-bl wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The docstrings and standard usage examples allow passing lowercase values like
driver.orientation = 'landscape'. While the setter validatedvalue.upper()against the allowed values['LANDSCAPE', 'PORTRAIT'], it previously forwarded the rawvalueto the Appium server command payload instead of the normalized uppercase string.This PR normalizes
value.upper()in the command payload and adds a unit test verifying case normalization.Changes
appium/webdriver/webdriver.py: passvalue.upper()inCommand.SET_SCREEN_ORIENTATIONpayload.test/unit/webdriver/webdriver_test.py: addtest_orientation_setter_normalizes_caseto verify lowercase inputs ('landscape', 'portrait') are sent as uppercase.