docs(divider): Add Storybook story and docs page - #1208
Merged
Conversation
Co-Authored-By: Claude <noreply@anthropic.com>
frankieyan
force-pushed
the
divider-storybook-story
branch
from
September 7, 2026 22:28
3ca75c3 to
0198543
Compare
frankieyan
marked this pull request as ready for review
September 8, 2026 04:06
frankieyan
added
the
👀 Show PR
doistbot
reviewed
Sep 8, 2026
doistbot
left a comment
doistbot
left a comment
Member
There was a problem hiding this comment.
This PR adds a Storybook story and docs page for the Divider, following the repo's existing CSF 3 and MDX conventions.
Few things worth tightening:
- The docs describe the weights in increasing-contrast order (
secondary,primary,tertiary), but the story renders them asprimary,secondary,tertiary— reorder the array so the example matches the documented comparison.
I also left one optional follow-up note in the details below.
Optional follow-up note (1)
src/divider/divider.mdx:24: This ordering claim doesn't hold across themes. In dark mode the divider tokens flip: per the values used in prose.stories.tsx (tertiary #323839 vs #202020 background), tertiary is the faintest and secondary is the middle one. Consider scoping the ordering to light mode or dropping the absolute claim.
frankieyan
requested review from
a team and
engfragui
and removed request for
a team
September 8, 2026 04:46
Contributor
|
🎉 This PR is included in version 37.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
This adds a story for the Divider component.
PR Checklist