Skip to content

fix(deps): update @doist/comms-sdk to 2.0.2 - #54

Merged
scottlovegrove merged 1 commit into
mainfrom
fix/comms-sdk-2.0.2
Aug 25, 2026
Merged

scottlovegrove merged 1 commit into
mainfrom
fix/comms-sdk-2.0.2

Conversation

@scottlovegrove

Copy link
Copy Markdown
Collaborator

Picks up Doist/comms-sdk-typescript#69, released as @doist/comms-sdk@2.0.2.

Why it matters here

Attachment uploads have never reached the server with a file attached. The SDK built the multipart body with the global FormData while dispatching through undici's own fetch, which does not recognise that class and stringifies it — so every upload was sent as the literal "[object FormData]" with content-type: text/plain.

That is exactly the path this CLI takes: td thread create --file and td thread reply --file go through uploadAttachments in src/lib/attachments.tsclient.attachments.upload.

Verification

npm test (858 tests), npm run type-check, npm run lint:check and npm run check:skill-sync all green on Node 24.18.0 and Node 26.4.0.

Also exercised the real upload path end to end against a local server with no mocks — openLocalFileAsBlobattachments.upload, the same two calls lib/attachments.ts makes:

node 24.18.0 / 26.4.0 | comms-sdk 2.0.2 — CLI upload path, no mocks
  content-type : multipart/form-data; boundary=----comms-sdk-…
  multipart    : true
  file bytes   : true

Before the SDK fix the same harness reported content-type: text/plain;charset=UTF-8 and a body of "[object FormData]".

🤖 Generated with Claude Code

2.0.2 fixes attachment uploads, which had never reached the server with
a file attached: the SDK built the body with the global FormData while
dispatching through undici's own fetch, which does not recognise it, so
every upload was sent as the literal string "[object FormData]".

That is the path `td thread create --file` and `td thread reply --file`
take, through lib/attachments.ts.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@scottlovegrove scottlovegrove self-assigned this Aug 25, 2026
@doistbot
doistbot requested a review from pedroalves0 August 25, 2026 11:48

@doistbot doistbot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR updates fix(deps): update @doist/comms-sdk to 2.0.2. No issues were flagged in the reviewed diff.

Share FeedbackReview Logs

@scottlovegrove scottlovegrove added the 👀 Show PR PR must be reviewed before or after merging label Aug 25, 2026
@scottlovegrove
scottlovegrove merged commit bc17f3d into main Aug 25, 2026
7 checks passed
@scottlovegrove
scottlovegrove deleted the fix/comms-sdk-2.0.2 branch August 25, 2026 12:03
doist-release-bot Bot added a commit that referenced this pull request Aug 25, 2026
## [2.0.4](v2.0.3...v2.0.4) (2026-08-25)

### Bug Fixes

* **deps:** update @doist/comms-sdk to 2.0.2 ([#54](#54)) ([bc17f3d](bc17f3d))
@doist-release-bot

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 2.0.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@craigcarlyle

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released 👀 Show PR PR must be reviewed before or after merging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants