fix(deps): update @doist/comms-sdk to 2.0.2 - #54
Merged
Merged
Conversation
2.0.2 fixes attachment uploads, which had never reached the server with a file attached: the SDK built the body with the global FormData while dispatching through undici's own fetch, which does not recognise it, so every upload was sent as the literal string "[object FormData]". That is the path `td thread create --file` and `td thread reply --file` take, through lib/attachments.ts. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
doistbot
reviewed
Aug 25, 2026
doistbot
left a comment
Member
There was a problem hiding this comment.
This PR updates fix(deps): update @doist/comms-sdk to 2.0.2. No issues were flagged in the reviewed diff.
doist-release-bot Bot
added a commit
that referenced
this pull request
Aug 25, 2026
## [2.0.4](v2.0.3...v2.0.4) (2026-08-25) ### Bug Fixes * **deps:** update @doist/comms-sdk to 2.0.2 ([#54](#54)) ([bc17f3d](bc17f3d))
Contributor
|
🎉 This PR is included in version 2.0.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up Doist/comms-sdk-typescript#69, released as
@doist/comms-sdk@2.0.2.Why it matters here
Attachment uploads have never reached the server with a file attached. The SDK built the multipart body with the global
FormDatawhile dispatching through undici's ownfetch, which does not recognise that class and stringifies it — so every upload was sent as the literal"[object FormData]"withcontent-type: text/plain.That is exactly the path this CLI takes:
td thread create --fileandtd thread reply --filego throughuploadAttachmentsinsrc/lib/attachments.ts→client.attachments.upload.Verification
npm test(858 tests),npm run type-check,npm run lint:checkandnpm run check:skill-syncall green on Node 24.18.0 and Node 26.4.0.Also exercised the real upload path end to end against a local server with no mocks —
openLocalFileAsBlob→attachments.upload, the same two callslib/attachments.tsmakes:Before the SDK fix the same harness reported
content-type: text/plain;charset=UTF-8and a body of"[object FormData]".🤖 Generated with Claude Code