Skip to content

fix: upgrade Comms SDK to 2.0.1 - #53

Merged
gnapse merged 2 commits into
mainfrom
ernesto/upgrade-comms-sdk-2.0.1
Aug 24, 2026
Merged

gnapse merged 2 commits into
mainfrom
ernesto/upgrade-comms-sdk-2.0.1

Conversation

@gnapse

@gnapse gnapse commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Summary

  • upgrade @doist/comms-sdk from 0.11.0 to 2.0.1
  • handle restricted workspace-user profiles introduced by SDK 2.x
  • preserve nullable email output for restricted channel and group members

Related

Testing

  • npm run type-check
  • npm test
  • npm run lint:check
  • npm run build
  • npm run check:skill-sync

Fixes #52

@doistbot
doistbot requested a review from henningmu August 24, 2026 20:08
@gnapse gnapse self-assigned this Aug 24, 2026
@gnapse gnapse added the 👀 Show PR PR must be reviewed before or after merging label Aug 24, 2026

@doistbot doistbot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This upgrades @doist/comms-sdk to 2.0.1 and nulls emails for restricted workspace users in channel and group member output.

Few things worth tightening:

  • The restricted-user fixtures in the channel and group tests omit email, so email: null would pass even without the isRestrictedWorkspaceUser guard. Give those fixtures an email so the assertions actually prove it is stripped.

I also left one optional follow-up note in the details below.

Optional follow-up note (1)
  • P3 src/commands/channel/membership-helpers.ts:23: fetchUsersByIds returns any user resolved by getUserById, which can be either visible or restricted. The return type and map instantiation should use WorkspaceUser instead of VisibleWorkspaceUser so callers receive the accurate union type before narrowing with isRestrictedWorkspaceUser.

Share FeedbackReview Logs

Comment thread src/commands/channel/members.test.ts
Comment thread src/commands/groups/groups.test.ts
@gnapse
gnapse merged commit d4e207a into main Aug 24, 2026
7 checks passed
@gnapse
gnapse deleted the ernesto/upgrade-comms-sdk-2.0.1 branch August 24, 2026 20:28
doist-release-bot Bot added a commit that referenced this pull request Aug 24, 2026
## [2.0.3](v2.0.2...v2.0.3) (2026-08-24)

### Bug Fixes

* upgrade Comms SDK to 2.0.1 ([#53](#53)) ([d4e207a](d4e207a))
@doist-release-bot

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 2.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released 👀 Show PR PR must be reviewed before or after merging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tdc conversation done returns 404 and never archives

2 participants