Add smoketests using JSON HTTP body in PUT#1589
Merged
Merged
Conversation
bpfoley
changed the title
cpeel
reviewed
Jun 11, 2026
Adding some breadcrumbs for the next developer who needs to learn how the smoketests work. I'd completely paged all this out.
...to end-to-end test the API a little more.
This is required by the site variables (particularly _CODE_DIR) defined by SETUP/tests/ci_configuration.sh The pageload_smoketest.py must also be run from $_CODE_DIR, and it already fails if it can't read pinc/site_vars.php. Make this failure more explicit.
cpeel
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.