ENG-1909 Add no-op Next.js content upsert endpoint#1220
Open
maparent wants to merge 3 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
maparent
force-pushed
the
eng-1909-add-no-op-nextjs-content-upsert-endpoint
branch
from
4cd8e3f to
7fc6f80
Compare
maparent
force-pushed
the
eng-1909-add-no-op-nextjs-content-upsert-endpoint
branch
from
7fc6f80 to
d43d61e
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
maparent
force-pushed
the
eng-2017-add-converter-for-crossapp-schemas-to-localconceptdatainput
branch
2 times, most recently
from
1127f9a to
284254a
Compare
maparent
force-pushed
the
eng-1909-add-no-op-nextjs-content-upsert-endpoint
branch
from
615145c to
9445331
Compare
maparent
force-pushed
the
eng-1909-add-no-op-nextjs-content-upsert-endpoint
branch
from
9445331 to
856b6fc
Compare
maparent
changed the base branch from
eng-2017-add-converter-for-crossapp-schemas-to-localconceptdatainput
to
eng-2036-simplify-the-cross-app-node-contract
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://linear.app/discourse-graphs/issue/ENG-1909/add-no-op-nextjs-content-upsert-endpoint
Content upsert, based on cross-app types.
This introduces a StandaloneCrossAppContent type for upserting contents outside of concepts, following existing sync functions.
Rationale : This is the closest to the current upsert_content practices, since the upsert unification has been delayed. So it should make eng-1824 as easy as possible.
There is an alternative approach: Do not create StandaloneCrossAppContent, but send the CrossAppNode with the standalone contents; and extract just the contents in the endpoint. In the longer run that is the right approach; but it is only optimal if we are doing the unification of upsert_content and upsert_concepts at the same time, which goes against PR minimalism. But I'm happy to revisit.
Also: I have not, in this PR, introduced a bulk conversion utility function, which could be more optimal in some cases. I think it is worth doing, but clearly a separate scope.
https://www.loom.com/share/202c49deb3014d2e8f60632f38ff71b4