Readme: Implement syntax highlighting via giallo#310
Draft
nicoburns wants to merge 1 commit into
Draft
Conversation
nicoburns
force-pushed
the
giallo-highlighting
branch
2 times, most recently
from
a939fe3 to
410907d
Compare
Signed-off-by: Nico Burns <nico@nicoburns.com>
nicoburns
force-pushed
the
giallo-highlighting
branch
from
410907d to
b074f14
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses https://github.com/getzola/giallo to implement syntax highlighting in the
readmemarkdown preview app.A production build of the README app with this PR and all language grammars and themes enabled is 17MB (up from ~14-15mb without syntax highlighting) which seems quite reasonable for the functionality gained.
Leaving this as a draft pending the outcome of discussions around licensing getzola/giallo#25