refactor(scaling): inline hot paths, native safe area, encapsulation cleanup - #8
Merged
Merged
Conversation
…cleanup - perf: convert scalar Numeric scaling directly to CGFloat (drop the cgFloatValue dynamic-cast bridge from the scalar path) and mark the scalar + FastScale paths @inlinable so consumers inline them cross-module - fix: batch integer bridge uses full-range CGFloat(v) (was trapping above Int.max); guard measurePerformance against zero iterations - refactor(metrics): keep ScreenUtil's safe-area accessors and ScreenMetrics fields, but source the values from the native window at snapshot rebuild and store them as raw CGFloats on Snapshot. The SafeAreaInsets wrapper struct is removed. nativeSafeArea() is hardened: foreground-active scene, keyWindow, watchOS/tvOS platform guards - refactor(core): derive Snapshot.default from platform defaults; internalize ScreenDimensions - docs: correct CLAUDE.md Module Map Internal/ rows No public safe-area signature changes; 108 tests pass; builds clean under Swift 6 strict concurrency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No public safe-area signature changes; 108 tests pass; builds clean under Swift 6 strict concurrency.