Skip to content

Change Generator update_macros call to just update current macros - #261

Merged
OCopping merged 1 commit into
mainfrom
fix-updating-macros
Aug 10, 2026
Merged

Change Generator update_macros call to just update current macros#261
OCopping merged 1 commit into
mainfrom
fix-updating-macros

Conversation

@OCopping

Copy link
Copy Markdown
Collaborator

This is instead of wiping out old dictionary with the updated_macros one.
This would cause issues if extra macros were defined in techui-support.yaml for the screen that are not a part of the prefix, as they would be cleared. An example of which is for the multipositioner embed screen.

  positioner.multipositioner:
    prefix: "{{ P }}"
    macros:
      - P
      - MP
    screens:
      - file: positioner/positioner_embed.bob
        type: embedded

…tead of wiping out old dictionary

This would cause issues if extra macros were defined in
techui-support.yaml for the screen that weren't a part of the prefix, as
they would be cleared. An example of which is for the multipositioner
embed screen.
@OCopping
OCopping force-pushed the fix-updating-macros branch from 40f34c3 to 294e221 Compare August 10, 2026 08:29
@codecov

codecov Bot commented Aug 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.04%. Comparing base (7f9a915) to head (294e221).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #261   +/-   ##
=======================================
  Coverage   96.03%   96.04%           
=======================================
  Files          13       13           
  Lines         984      985    +1     
=======================================
+ Hits          945      946    +1     
  Misses         39       39           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@OCopping
OCopping merged commit 7cb070d into main Aug 10, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants