Change Generator update_macros call to just update current macros - #261
Merged
Conversation
…tead of wiping out old dictionary This would cause issues if extra macros were defined in techui-support.yaml for the screen that weren't a part of the prefix, as they would be cleared. An example of which is for the multipositioner embed screen.
OCopping
force-pushed
the
fix-updating-macros
branch
from
August 10, 2026 08:29
40f34c3 to
294e221
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #261 +/- ##
=======================================
Coverage 96.03% 96.04%
=======================================
Files 13 13
Lines 984 985 +1
=======================================
+ Hits 945 946 +1
Misses 39 39 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
adedamola-sode
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is instead of wiping out old dictionary with the
updated_macrosone.This would cause issues if extra macros were defined in
techui-support.yamlfor the screen that are not a part of the prefix, as they would be cleared. An example of which is for the multipositioner embed screen.