Repository navigation
Conversation
- Progress: use the primary.main sx shortcut so it follows the colour mode - Practical guidance: add the "Read intent colours from theme.vars" section - Colour docs: show theme.vars.palette in the role tables and examples - Changelog entries
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on the design system website I noticed a discrepancy: the DS needs
theme.varsfor intent colours, but our docs and one component (Progress) didn't follow it.Progressnow reads its primary colour throughtheme.vars, so it follows the colour mode instead of staying at the light valuetheme.vars.palettefor intent colours, matching the design system guideProgress