Handle simultaneous update and deprecate/restore - #79
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #79 +/- ##
==========================================
- Coverage 99.48% 99.48% -0.01%
==========================================
Files 27 27
Lines 979 978 -1
==========================================
- Hits 974 973 -1
Misses 5 5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ptsOSL
left a comment
There was a problem hiding this comment.
Looks good to me.
Out of curiosity, is it possible to create a new release with deprecated=true? And could this cause issues
You can with We don't explicitly test it for a new deployment, but as |
At the moment, if you update a Module's contents as well as deprecate or restore it, only the update takes effect on sync. This means that the compare command will fail the next time it is run, as the modulefile is not in the correct location.
This only needed a fix to validation as deploy was already capable of handling Modules that fell into more than one category.
When creating the tests, it was clear that some places used "active" and others "live" to refer to a non-deprecated module, so I have cleared this up.