Skip to content

Update style to use all vertical space in plots - #282

Merged
VictoriaBeilsten-Edmands merged 1 commit into
mainfrom
vbe/use-vertical-space
Nov 13, 2026
Merged

VictoriaBeilsten-Edmands merged 1 commit into
mainfrom
vbe/use-vertical-space

Conversation

@VictoriaBeilsten-Edmands

Copy link
Copy Markdown
Collaborator

For plots with optional toolbars (all except TableDisplay), conditionally set gridTemplateRows based on if it has a toolbar or not.

@PeterC-DLS

PeterC-DLS commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Is it possible to use a single CSS class for this? The toolbar conditional could be a `:has()' selector

@VictoriaBeilsten-Edmands

Copy link
Copy Markdown
Collaborator Author

I've used a couple of CSS classes for this. I tried to use a has selector on .toolbar but couldn't get it to work so had to check number of children instead.

@PeterC-DLS PeterC-DLS left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VictoriaBeilsten-Edmands
VictoriaBeilsten-Edmands added this pull request to the merge queue Nov 13, 2026
Merged via the queue into main with commit c3057a7 Nov 13, 2026
3 checks passed
@VictoriaBeilsten-Edmands
VictoriaBeilsten-Edmands deleted the vbe/use-vertical-space branch November 13, 2026 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants