Skip to content

refactor: Add defaults for authZ policy - #1621

Open
ZohebShaikh wants to merge 2 commits into
DiamondLightSource:mainfrom
ZohebShaikh:add-defaults-for-policy
Open

refactor: Add defaults for authZ policy#1621
ZohebShaikh wants to merge 2 commits into
DiamondLightSource:mainfrom
ZohebShaikh:add-defaults-for-policy

Conversation

@ZohebShaikh

@ZohebShaikh ZohebShaikh commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

It feels slightly awkward to have to specify the policy values explicitly. I think having sensible defaults would provide a better UX.

They could also be included in Copier, but having them as defaults would mean one less thing to worry about when running copier update.

@ZohebShaikh
ZohebShaikh requested a review from a team as a code owner August 11, 2026 15:40
@ZohebShaikh
ZohebShaikh force-pushed the add-defaults-for-policy branch from 4b7c6c4 to fab42ee Compare August 11, 2026 15:43
@codecov

codecov Bot commented Aug 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.96%. Comparing base (2108ee0) to head (a2eb261).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1621   +/-   ##
=======================================
  Coverage   95.96%   95.96%           
=======================================
  Files          45       45           
  Lines        3317     3317           
=======================================
  Hits         3183     3183           
  Misses        134      134           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ZohebShaikh ZohebShaikh changed the title Add defaults for authZ policy refactor: Add defaults for authZ policy Aug 11, 2026
@ZohebShaikh

Copy link
Copy Markdown
Contributor Author

@shree-iyengar-dls If this change gets merged in Then the only docs that should be added is that please point it to the authorization provider which is opa.diamond.ac.uk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant