ci: set explicit read-only GITHUB_TOKEN permissions on JSON validation workflow - #3765
Open
bunlongheng wants to merge 1 commit into
Open
ci: set explicit read-only GITHUB_TOKEN permissions on JSON validation workflow#3765bunlongheng wants to merge 1 commit into
bunlongheng wants to merge 1 commit into
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
noticed the JSON_VALIDATION workflow runs with the repo's default GITHUB_TOKEN permissions since it never declares any. the job only checks out the repo, restores the npm cache and runs the validator, so it doesn't need write access to anything. this adds a top-level permissions block with contents: read so the token handed to the run is read-only.
mostly cheap insurance: npm i executes lifecycle scripts from every transitive dependency on each PR, and the current lockfile still pins some pretty old ones (nodemon 2.x tree). if any of those ever ship a bad postinstall, a read-only token means it can't push to the repo. no behavior change for the validation itself.