Repository navigation
The user guide says apply refuses on any slot but the committed one, and how to put that right - #256
Merged
Merged
Conversation
…and how the refusal's message puts that right #238 made kryptik-update apply run from the committed slot only; the guide's list of refusals named an armed trial, a degraded state and a failed trial. The recovery paragraph's overlong line is rewrapped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong. Since #238,
kryptik-update apply(andkryptik update apply, which runs it) refuses on any slot but the one the ESP names as committed. A slot picked in the firmware's boot menu is reported uncommitted by boot-success, and an apply from it would have written over the one release known to boot. The user guide's list of refusals still named only an armed trial, a degraded state and a failed trial. So a reader who booted the other slot would meet a refusal the guide never mentions.What changed.
docs/user-guide.md's update section names that refusal and what its message offers: boot the committed slot, or make the running one committed from the medium (kryptik-recover --commit-slot). The recovery paragraph above it, where one line ran to 120 characters, is rewrapped with no word changed.How the run proves it. This is docs only, and no script reads this section. The refusal's wording is
from_committedintools/update/kryptik-update, andtools/tests/update-esp.shcovers it.