Skip to content

ci: remove unused package scripts, backport fixes into tlk.ps1#1800

Merged
Benoît Cortier (CBenoit) merged 1 commit into
masterfrom
copilot/refactor-package-scripts
May 26, 2026
Merged

ci: remove unused package scripts, backport fixes into tlk.ps1#1800
Benoît Cortier (CBenoit) merged 1 commit into
masterfrom
copilot/refactor-package-scripts

Conversation

Copilot AI commented May 26, 2026

Copy link
Copy Markdown
Contributor

ci/package-gateway-deb.ps1 and ci/package-gateway-rpm.ps1 were introduced in #1246 as a refactor of the Linux packaging logic out of tlk.ps1, but were never wired into any workflow. The code diverged, and the split scripts accumulated both fixes and bugs. Rather than completing the incomplete refactor, this deletes the dead scripts and backports the meaningful fixes.

Deleted

  • ci/package-gateway-deb.ps1 — unreferenced, gateway-only, has a broken $Target variable
  • ci/package-gateway-rpm.ps1 — unreferenced, gateway-only

Backported into tlk.ps1

  • chmod +x $RulesFile after template generation — fixes dpkg-buildpackage warning about debian/rules missing the execute bit
  • RPM now generates its own copyright file instead of reusing the Debian-formatted one, removing an implicit deb→rpm ordering dependency:
    $RpmCopyrightFile = Join-Path $OutputPath "copyright_rpm"
    "Copyright $($(Get-Date).Year) Devolutions Inc. All rights reserved." | Set-Content -Path $RpmCopyrightFile

Cleaned up

  • Removed the {{ dh_shlibdeps }} template token from both package/Linux/gateway/template/rules and package/AgentLinux/agent/template/rules (empty override kept to suppress default behavior on cross-compiled binaries)
  • Removed corresponding $DhShLibDepsOverride variable and token-passing in tlk.ps1

…t scripts

- Delete unused ci/package-gateway-deb.ps1 and ci/package-gateway-rpm.ps1
- Add chmod +x on debian/rules after template generation (backport from split scripts)
- Generate RPM-specific copyright instead of reusing the Debian copyright file
- Remove unused dh_shlibdeps template token from rules templates and tlk.ps1

Agent-Logs-Url: https://github.com/Devolutions/devolutions-gateway/sessions/70a4c853-7e26-44b5-93d2-d50bc70d020e

Co-authored-by: CBenoit <3809077+CBenoit@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown

Let maintainers know that an action is required on their side

  • Add the label release-required Please cut a new release (Devolutions Gateway, Devolutions Agent, Jetsocat, PowerShell module) when you request a maintainer to cut a new release (Devolutions Gateway, Devolutions Agent, Jetsocat, PowerShell module)

  • Add the label release-blocker Follow-up is required before cutting a new release if a follow-up is required before cutting a new release

  • Add the label publish-required Please publish libraries (`Devolutions.Gateway.Utils`, OpenAPI clients, etc) when you request a maintainer to publish libraries (Devolutions.Gateway.Utils, OpenAPI clients, etc.)

  • Add the label publish-blocker Follow-up is required before publishing libraries if a follow-up is required before publishing libraries

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes unused Linux gateway packaging scripts and consolidates the relevant fixes back into the active ci/tlk.ps1 packaging path.

Changes:

  • Deletes unreferenced standalone Debian/RPM gateway packaging scripts.
  • Adds executable permission handling for generated Debian rules.
  • Generates an RPM-specific copyright file and removes the unused dh_shlibdeps template token.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
ci/tlk.ps1 Backports packaging fixes into the live Linux packaging workflow.
ci/package-gateway-deb.ps1 Removes unused Debian gateway packaging script.
ci/package-gateway-rpm.ps1 Removes unused RPM gateway packaging script.
package/Linux/gateway/template/rules Removes unused dh_shlibdeps token from gateway Debian rules template.
package/AgentLinux/agent/template/rules Removes unused dh_shlibdeps token from agent Debian rules template.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@CBenoit Benoît Cortier (CBenoit) marked this pull request as ready for review May 26, 2026 13:23
@CBenoit Benoît Cortier (CBenoit) changed the title chore(ci): remove unused package scripts, backport fixes into tlk.ps1 ci: remove unused package scripts, backport fixes into tlk.ps1 May 26, 2026
@CBenoit Benoît Cortier (CBenoit) enabled auto-merge (squash) May 26, 2026 13:24
@CBenoit

Copy link
Copy Markdown
Member

Resulting .DEB and .RPM packages are still behaving as expected even with the backported fixes.

@CBenoit Benoît Cortier (CBenoit) merged commit 3849d69 into master May 26, 2026
54 checks passed
@CBenoit Benoît Cortier (CBenoit) deleted the copilot/refactor-package-scripts branch May 26, 2026 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants