ci: remove unused package scripts, backport fixes into tlk.ps1#1800
Conversation
…t scripts - Delete unused ci/package-gateway-deb.ps1 and ci/package-gateway-rpm.ps1 - Add chmod +x on debian/rules after template generation (backport from split scripts) - Generate RPM-specific copyright instead of reusing the Debian copyright file - Remove unused dh_shlibdeps template token from rules templates and tlk.ps1 Agent-Logs-Url: https://github.com/Devolutions/devolutions-gateway/sessions/70a4c853-7e26-44b5-93d2-d50bc70d020e Co-authored-by: CBenoit <3809077+CBenoit@users.noreply.github.com>
Let maintainers know that an action is required on their side
|
There was a problem hiding this comment.
Pull request overview
This PR removes unused Linux gateway packaging scripts and consolidates the relevant fixes back into the active ci/tlk.ps1 packaging path.
Changes:
- Deletes unreferenced standalone Debian/RPM gateway packaging scripts.
- Adds executable permission handling for generated Debian
rules. - Generates an RPM-specific copyright file and removes the unused
dh_shlibdepstemplate token.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
ci/tlk.ps1 |
Backports packaging fixes into the live Linux packaging workflow. |
ci/package-gateway-deb.ps1 |
Removes unused Debian gateway packaging script. |
ci/package-gateway-rpm.ps1 |
Removes unused RPM gateway packaging script. |
package/Linux/gateway/template/rules |
Removes unused dh_shlibdeps token from gateway Debian rules template. |
package/AgentLinux/agent/template/rules |
Removes unused dh_shlibdeps token from agent Debian rules template. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Resulting .DEB and .RPM packages are still behaving as expected even with the backported fixes. |
ci/package-gateway-deb.ps1andci/package-gateway-rpm.ps1were introduced in #1246 as a refactor of the Linux packaging logic out oftlk.ps1, but were never wired into any workflow. The code diverged, and the split scripts accumulated both fixes and bugs. Rather than completing the incomplete refactor, this deletes the dead scripts and backports the meaningful fixes.Deleted
ci/package-gateway-deb.ps1— unreferenced, gateway-only, has a broken$Targetvariableci/package-gateway-rpm.ps1— unreferenced, gateway-onlyBackported into
tlk.ps1chmod +x $RulesFileafter template generation — fixesdpkg-buildpackagewarning aboutdebian/rulesmissing the execute bitCleaned up
{{ dh_shlibdeps }}template token from bothpackage/Linux/gateway/template/rulesandpackage/AgentLinux/agent/template/rules(empty override kept to suppress default behavior on cross-compiled binaries)$DhShLibDepsOverridevariable and token-passing intlk.ps1