Add streaming recording heartbeat - #185
Draft
irvingouj@Devolutions (irvingoujAtDevolution) wants to merge 1 commit into
Draft
Add streaming recording heartbeat#185irvingouj@Devolutions (irvingoujAtDevolution) wants to merge 1 commit into
irvingouj@Devolutions (irvingoujAtDevolution) wants to merge 1 commit into
Conversation
Submit the current output-mirror framebuffer at 30 FPS while recording to a named pipe. Sparse RDP paints otherwise produce low-density VP8 WebM that Media Foundation buffers until the stream ends instead of rendering live. Local file recording keeps its configured frame rate and does not start the heartbeat. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
Implementation notes:
Validation:
Note Human-tuned, LLM-assisted content. |
Copilot started reviewing on behalf of
irvingouj@Devolutions (irvingoujAtDevolution)
August 25, 2026 22:12
View session
There was a problem hiding this comment.
Pull request overview
Adds heartbeat frames for named-pipe video recordings to keep low-motion RDP streams decodable during live playback.
Changes:
- Enforces a 30 FPS minimum for streaming recordings.
- Adds a heartbeat worker with startup and shutdown handling.
- Leaves local-file frame rates unchanged.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+58
to
+59
| MsRdpEx_VideoRecorder_UpdateFrame(ctx->videoRecorder, ctx->bitmapData, | ||
| 0, 0, ctx->bitmapWidth, ctx->bitmapHeight, ctx->bitmapStep); |
Comment on lines
+73
to
+75
| if (ctx->heartbeatThread) | ||
| { | ||
| WaitForSingleObject(ctx->heartbeatThread, INFINITE); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Emit output-mirror heartbeat frames while recording to a named pipe so low-motion RDP sessions remain decodable during live playback.
The heartbeat is limited to streaming recordings. Local file recording keeps its configured frame rate.