fix(report): 이전 리포트 목록 기준 시각을 분석 완료 시각으로 보정#195
Merged
Conversation
GET /api/v2/monthly-report/all 응답의 createdAt 필드명을 유지하되 값을 analyzedAt으로 매핑해 실패 레코드 재사용 시 최초 생성 시각이 노출되지 않도록 수정
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 요약(Summary)
GET /api/v2/monthly-report/all응답의createdAt필드 값을created_at이 아닌analyzedAt기준으로 보정주요 변경사항
getAnalyzedAt()값을createdAt응답 필드에 매핑createdAt필드의 OpenAPI 설명을 “목록 표시 기준 시각(리포트 분석 완료 시각)”으로 수정MonthlyReport에 추가됐던 불필요한CreatableEntity상속 제거createdAt응답값이analyzedAt기반인지 검증하도록 수정검증
.\gradlew.bat compileJava.\gradlew.bat test --tests "com.devkor.ifive.nadab.domain.monthlyreport.application.MonthlyReportQueryServiceV2Test"git diff --check참고 / 리스크
createdAt그대로 사용🔗 Related Issue
💬 공유사항
✅ PR Checklist
PR이 다음 요구 사항을 충족하는지 확인하세요.