feat(report): 이전 리포트 목록 조회에 페이지네이션 응답 추가#192
Merged
Merged
Conversation
GET /api/v2/monthly-report/all 응답을 페이지 객체로 변경하고 page, size 쿼리 파라미터를 추가함. 기존 통합 정렬 규칙은 유지하면서 전체 개수, 페이지 수, 이전/다음 페이지 여부를 함께 반환하도록 개선함
MonthlyReportQueryServiceV2Test에 첫 페이지와 마지막 페이지 메타데이터, MONTHLY 필터, 빈 결과, 잘못된 page/size 요청 검증을 추가함
GET /api/v2/monthly-report/all 문서에 type별 의미, page/size 규칙, 페이지 응답 필드 활용 방법, 정렬 순서, 상세 조회 라우팅 규칙을 보강함
Collaborator
|
LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 요약(Summary)
GET /api/v2/monthly-report/allAPI에 페이지네이션 응답을 추가했습니다.page,size기반으로 목록을 잘라 반환하도록 변경했습니다.주요 변경사항
List<AllReportItemResponseV2>응답을AllReportListResponseV2페이지 객체 응답으로 변경items,totalCount,currentPage,pageSize,totalPages,hasPrevious,hasNext추가page기본값 1,size기본값 7,size최대값 50 적용VALIDATION_FAILED로 처리MonthlyReportQueryServiceV2Test에 첫 페이지, 마지막 페이지, MONTHLY 필터, 빈 결과, 잘못된 page/size 검증 추가검증
.\gradlew.bat compileJava.\gradlew.bat test --tests "com.devkor.ifive.nadab.domain.monthlyreport.application.MonthlyReportQueryServiceV2Test"git diff --check🔗 Related Issue
💬 공유사항
✅ PR Checklist
PR이 다음 요구 사항을 충족하는지 확인하세요.