Gulp: localization generate-community-locales gulp task move to nx ex…#34286
Open
vorobey wants to merge 4 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Migrates the generate-community-locales gulp task into an Nx executor within nx-infra-plugin, and wires the DevExtreme package/build scripts to invoke the new target for in-place normalization of community locale message files.
Changes:
- Added a new
devextreme-nx-infra-plugin:generate-community-localesexecutor (schema, implementation, and e2e tests). - Registered the executor in
packages/nx-infra-plugin/executors.jsonand documented the migration inAGENTS.md. - Switched DevExtreme’s
build:community-localizationto an Nx target and updated the gulp task + package script to delegate to it.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/nx-infra-plugin/src/executors/generate-community-locales/schema.ts | Adds TypeScript options interface for the new executor. |
| packages/nx-infra-plugin/src/executors/generate-community-locales/schema.json | Defines Nx schema (defaults + option descriptions) for executor configuration. |
| packages/nx-infra-plugin/src/executors/generate-community-locales/generate-community-locales.impl.ts | Implements locale file normalization logic (template from default locale, fill translations, keep formatting). |
| packages/nx-infra-plugin/src/executors/generate-community-locales/executor.ts | Exposes the executor entrypoint for Nx. |
| packages/nx-infra-plugin/src/executors/generate-community-locales/executor.e2e.spec.ts | Adds e2e coverage validating normalization behavior and failure mode. |
| packages/nx-infra-plugin/executors.json | Registers the new executor in the plugin. |
| packages/nx-infra-plugin/AGENTS.md | Documents the gulp→Nx migration mapping and operational details for the new target. |
| packages/devextreme/project.json | Adds build:community-localization target using the new executor (non-cached, in-place). |
| packages/devextreme/package.json | Updates build:community-localization script to call Nx target directly. |
| packages/devextreme/build/gulp/localization.js | Replaces gulp-stream implementation with a shell delegation to the Nx target. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Andrey Vorobev <dobriy.kaa@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.