Grids - Stabilize tests (Part 2 & 3) by Tucchhaa · Pull Request #34221 · DevExpress/DevExtreme

Tucchhaa · 2026-07-07T10:17:59Z

No description provided.

Tucchhaa · 2026-07-08T06:12:58Z

      await t.expect(draggingElement.exists).notOk();
    }
+
+    await triggerDragEnd(columnElement);


This test was stable, but page reloads are disabled in this fixture, so to prevent any leakage between tests I have added this.

Check, please, do we need desablePageReload fixture here or it can be omitted here

I think we need disablePageReloads in this file, cuz there are a lot of matrix tests. I added this clean-up line for prevention, because it's hard to detect the actual reason of flakiness: locally everything runs smoothly, test starts failing only when CI is slow

Tucchhaa · 2026-07-08T06:15:26Z

        { dataField: 'Column 1', visible: false },
        { dataField: 'Column 2' },
        { dataField: 'Column 3' },
-        { dataField: 'Column 4' },


This matrix tests iterates through [0, 1, 2] for gapIndex. With 4 columns, testcases for gapIndex==1 and gapIndex==2 basically test the same thing: drag from column chooser to the middle of header panel.

With 3 columns, gapIndex==2 now checks the case when column is dragged to the end of header panel

Tucchhaa · 2026-07-08T06:16:16Z

    .ok();

-  await treeList.apiShowErrorToast();
+  await treeList.apiShowErrorToast({ displayTime: 100000 });


toast could disappear before the screenshot is taken, which can lead to instability. So I have added more display time

Tucchhaa · 2026-07-08T06:17:25Z

-  await t
-    .expect(dataGrid.getLoadPanel().isVisible())
-    .ok();


race condition: load panel can hide before this check runs. The test name doesn't suggest that load panel has to be checked, so I have removed this expect

How is that possible if the AI request is still in progress?

I think we need this check because we want to verify that the load panel is initially displayed while the AI request is in progress. This behavior is also verified later in the test.

again, can we remove disablePageReload fixture here?

@Alyar666, you're right here. I have brought back the loadPanel visibility check. I think the reason of flakiness was that there was no await t.expect(isAIRequestPending()).ok();. I will run CI several times to verify that

@anna-shakhova this test file, doesn't have disablePageReloads

Tucchhaa · 2026-07-08T06:18:24Z

    [1],
  ];

+  await t.expect(dataGrid.getDataRow(1).element).ok();


wait for the row to appear before checking callback results

Tucchhaa · 2026-07-08T06:19:00Z

  await t
-    .pressKey('pagedown');
+    .pressKey('pagedown')
+    .expect(dataGrid.isReady()).ok();


pagedown/pageup cause dataSource load, so it's needed to wait for it to finish

Should this really be in the act section?

Tucchhaa · 2026-07-08T06:21:48Z


  await t.click(dataGrid.getHeaders().getHeaderRow(0).getHeaderCell(19).element);

-  await dataGrid.scrollBy(t, { left: 0 });


scrollBy accepts displacement and not the exact position. The ticket suggests that dataGrid has to be scrolled to left, but .scrollBy(t, { left: 0 }); has no effect

Tucchhaa · 2026-07-08T08:50:17Z

    // eslint-disable-next-line no-underscore-dangle
    dataGrid._getTemplate = () => ({
      render(options) {
-        setTimeout(() => {


timeouts can affect other tests, since page reloads are disabled

Tucchhaa · 2026-07-08T08:51:14Z

  height: 1500,
 }));

-test('edit => scroll => command, should not result in grid scrolling back to edit', async (t) => {


this test written strangely + this behavior won't reproduce in modern browsers, cuz when element is focused, the browser automatically scrolls to it

Tucchhaa · 2026-07-08T08:51:34Z

-    await t.wait(100);
+    await t
+      .pressKey('ctrl+end')
+      .expect(dataGrid.isReady()).ok();


ctrl+end causes datasource load, so need to wait for it

Signed-off-by: Eldar Iusupzhanov <84278206+Tucchhaa@users.noreply.github.com>

Tucchhaa · 2026-07-09T17:10:12Z

    })();
  });

-  test.meta({ unstable: true })(`Focus events should be called when pressing the Ctrl + End key when infinite scrolling is enabled (scrolling.useNative = ${useNativeScrolling})`, async (t) => {


There's a race condition in the datagrid's code on Ctrl+End in infinite scrolling:
(a) the scroll-driven focus application (_handleScroll → focusFirstOrLastCell), and
(b) the infinite-load append render, which re-renders/settles the rows but skips re-focusing.

I suggest to fix this test separately

Alyar666 · 2026-07-13T07:54:47Z

-    test.meta({ unstable: true })(`drag from columnChooser to headerPanel: from index ${columnIndex} to index ${gapIndex}`, async (t) => {
+    test(`drag from columnChooser to headerPanel: from index ${columnIndex} to index ${gapIndex}`, async (t) => {
      const cardView = new CardView('#container');
      await cardView.apiShowColumnChooser();


Shouldn't we check isReady here? Also, shouldn't we verify that the Column Chooser exists before accessing it?

isReady won't help here, because it indicates whether dataController finished loading data:

DevExtreme/packages/devextreme/js/__internal/grids/grid_core/data_controller/m_data_controller.ts

Line 389 in 4f7410d

return !this._isLoading;

In this test we don't care whether the data was loaded or not. Explicit wait for column chooser is also not needed, because there's an implement check:

const columnElement = getColumnItem(cardView, columnIndex, 'columnChooser');. Column element is a testcafe Selector, so testcafe will wait for the element to appear before doing anything with it

Alyar666 · 2026-07-13T08:00:12Z

      insertBeforeColumn,
      {
-        destinationOffsetX: 5,
+        destinationOffsetX: -(Math.floor(width) + 3), // 5px left of the left edge


// 5px left of the left edge

5px or 3px ?

Fixed. It's 3px because distance between columns in fluent is 6px

Alyar666 · 2026-07-13T08:11:35Z

    .ok();

-  await treeList.apiShowErrorToast();
+  await treeList.apiShowErrorToast({ displayTime: 100000 });


Is the toast destroyed after the test completes?

I have removed disablePageReloads, since there are only 2 tests in the file. That will guarantee that there's no leakage between the tests

Alyar666 · 2026-07-13T08:15:57Z

-  await t
-    .expect(dataGrid.getLoadPanel().isVisible())
-    .ok();


How is that possible if the AI request is still in progress?

Alyar666 · 2026-07-13T08:30:54Z

-    await t.pressKey('ctrl+end');
+    await t
+      .pressKey('ctrl+end')
+      .wait(500);


Can we avoid using wait here? For example, could we replace it with a check that a specific cell exists?

After taking a deeper look, all waits in the modified tests are useless, after keypress there is a check on testcafe Selector (i.e. .expect(dataGrid.getDataCell(19, 14).element.focused)), which means that Testcafe will poll cell's state until the condition is true. So testcafe already does the wait for us.

I will replace waits with dataGrid.isReady, but that won't fix flakiness completely (I already tried to use dataGrid.isReady). I suspect the fix should be on the datagrid's side

Alyar666 · 2026-07-13T08:31:06Z

-    await t.pressKey('ctrl+end');
+    await t
+      .pressKey('ctrl+end')
+      .wait(500);


Can we avoid using wait here? For example, could we replace it with a check that a specific cell exists?

removed all waits from this file

Alyar666 · 2026-07-13T08:34:21Z

-    await t.pressKey('ctrl+end');
+    await t
+      .pressKey('ctrl+end')
+      .wait(500);


Can we avoid using wait here? For example, could we replace it with a check that a specific cell exists?

removed all waits from this file

Alyar666 · 2026-07-13T08:34:25Z

-    await t.pressKey('ctrl+end');
+    await t
+      .pressKey('ctrl+end')
+      .wait(500);


Can we avoid using wait here? For example, could we replace it with a check that a specific cell exists?

I removed all t.wait from this file, except this one:

DevExtreme/e2e/testcafe-devextreme/tests/dataGrid/common/keyboardNavigation/keyboardNavigation.functional.ts

Line 3285 in c225896

.typeText(filterRowEditor.element, '_1')

Because:

that test is not flaky

it's hard to wait for the moment when the filter is applied

Alyar666 · 2026-07-13T08:38:16Z

    .ok();

-  await dataGrid.apiShowErrorToast();
+  await dataGrid.apiShowErrorToast({ displayTime: 100000 });


Is the toast destroyed after the test completes?

removed disablePageReloads from this file

anna-shakhova · 2026-07-13T08:21:23Z

+    .expect(treeList.getToast().exists).ok();
+
+  await t
+    .wait(1000)


lets increase wait time a bit, show/hide toast is made with promise and setTimeout, and may take a little more than displayTime

ok, thanks, I have applied

anna-shakhova · 2026-07-13T08:29:13Z

-  await t
-    .expect(dataGrid.getLoadPanel().isVisible())
-    .ok();


again, can we remove disablePageReload fixture here?

anna-shakhova · 2026-07-13T08:33:01Z

-    await t.pressKey('ctrl+end');
+    await t
+      .pressKey('ctrl+end')
+      .wait(500);


Usage of t.wait is prohibited in testcafe tests and we want to remove all existing. Do we have some other assertion that can help here (ready, some element is visible or not, etc.)

Some for other added t.wait

I removed all t.wait from this file, except this one:

DevExtreme/e2e/testcafe-devextreme/tests/dataGrid/common/keyboardNavigation/keyboardNavigation.functional.ts

Line 3285 in c225896

.typeText(filterRowEditor.element, '_1')

Because:

that test is not flaky

it's hard to wait for the moment when the filter is applied

anna-shakhova · 2026-07-13T08:36:47Z

 // visual: fluent.blue.dark

-test.meta({ unstable: true })('Disabled toolbar buttons are not grayed out in Material themes (T1217416)', async (t) => {
+test('Disabled toolbar buttons should be grayed out in Material themes (T1217416)', async (t) => {


let add testing in Material theme and remove comments above

We have a lot of occurrences of // visual:
If you dont mind, I suggest to apply this change in another task, cuz this PR already has a lot of changes

anna-shakhova · 2026-07-13T08:54:54Z


-  public showToastError(message: string) {
-    this._toastViewController.showToast(message, { type: 'error' });
+  public showToastError(message: string, options?: ToastProperties) {


I don't like the idea to extend public method arguments for testing purposes only. I would prefer creating anothe api helper in testcafe model to manage toast behavior with smth like

(window as any).DevExpress.ui.dxToast.defaultOptions(options)

Nice suggestion, I have applied it

Tucchhaa · 2026-07-13T16:33:36Z

  assertFirstColumnHidden: (t: TestController, cardView: CardView) => Promise<void>;
  config: any; // TODO: add typing
 }) {
  test.meta({ unstable: true })(`column chooser in ${testModel.name} mode should work after multiple hide/show actions`, async (t) => {


Test is unstable in select mode: https://github.com/DevExpress/DevExtreme/actions/runs/29251945672/job/86861954473?pr=34221. I have tried different approaches to fix it, but none of them worked. So I decided to postpone its fix. I have added this test to the card for fixing tests

fix

fb68eca

Tucchhaa self-assigned this Jul 7, 2026

Tucchhaa added the 26_1 label Jul 7, 2026

Tucchhaa changed the title ~~DataGrid - Stabilize tests (Part 3)~~ Grids - Stabilize tests (Part 3) Jul 7, 2026

Tucchhaa added 4 commits July 7, 2026 16:35

split toast tests into 2

566518c

fix toast test

d1bbc32

stabilize

a62c9f1

fix tests

ee84401

Tucchhaa commented Jul 8, 2026

View reviewed changes

Tucchhaa marked this pull request as ready for review July 8, 2026 07:16

Tucchhaa requested a review from a team as a code owner July 8, 2026 07:16

apply kbn test fixes

6c0a5d6

Tucchhaa commented Jul 8, 2026

View reviewed changes

fix kbn tests

dad40bc

Tucchhaa changed the base branch from 26_1 to main July 8, 2026 11:26

Tucchhaa added 2 commits July 8, 2026 17:57

fix kbn tests

9bab139

fix flaky tests

7ac8962

Tucchhaa changed the title ~~Grids - Stabilize tests (Part 3)~~ Grids - Stabilize tests (Part 2 & 3) Jul 9, 2026

Tucchhaa added 4 commits July 9, 2026 13:25

fix cardview column drag

2b141b1

fix cardview columnchooser testt

c419f90

fix again

4603c3a

fix cardview test

f0030a7

Tucchhaa and others added 3 commits July 9, 2026 15:22

fix

16ebd6e

Signed-off-by: Eldar Iusupzhanov <84278206+Tucchhaa@users.noreply.github.com>

fix

4f896a3

Signed-off-by: Eldar Iusupzhanov <84278206+Tucchhaa@users.noreply.github.com>

stabilize

cdf9d31

Tucchhaa commented Jul 9, 2026

View reviewed changes

Tucchhaa added 5 commits July 9, 2026 23:44

fix another test

4b23b81

stabilize another test

230ea5e

refix

a969b23

fix ts

ffc7033

stabilize

4f7410d

Alyar666 requested changes Jul 13, 2026

View reviewed changes

anna-shakhova reviewed Jul 13, 2026

View reviewed changes

Tucchhaa added 5 commits July 13, 2026 17:10

apply review

16c6d6f

fix tests

c225896

skip kbn usntable tests

b8faee4

fix

f9bb795

skip unstable cardview test

7555c1d

Tucchhaa commented Jul 13, 2026

View reviewed changes

stabilize toast hiding test

468f08a


		await t.click(dataGrid.getHeaders().getHeaderRow(0).getHeaderCell(19).element);

		await dataGrid.scrollBy(t, { left: 0 });

Uh oh!

Conversation

Tucchhaa commented Jul 7, 2026

Uh oh!

Tucchhaa Jul 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Tucchhaa Jul 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Tucchhaa Jul 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Tucchhaa Jul 8, 2026 •

edited

Loading

Tucchhaa Jul 13, 2026 •

edited

Loading

Tucchhaa Jul 13, 2026 •

edited

Loading

Tucchhaa Jul 13, 2026 •

edited

Loading

Tucchhaa Jul 13, 2026 •

edited

Loading