feat: Add fs store to block manager - #1
Closed
DerekCuevas wants to merge 1 commit into
Closed
Conversation
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
|
|
||
| Ok(()) | ||
| } | ||
|
|
There was a problem hiding this comment.
Removed blocks reappear after loading from disk
The remove_block function only removes blocks from memory but doesn't delete the corresponding JSON file from disk. Since add_block persists blocks via persist_block, this creates an inconsistency where removed blocks will reappear after calling load_from_disk(). Any block that was added, removed, and then loaded from disk will be restored to memory unexpectedly.
Additional Locations (1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Introduces filesystem-backed storage for blocks and enables JSON (de)serialization across core types.
BlockManagerpersistence: newdata_dir,persist_block,load_from_disk,add_block_internal(persist), and constructorsnew/new_with_load; blocks saved as<hash>.jsonin./dataand loaded with orphan handlingSerialize/DeserializetoHash,BlockHeader,Block,Transaction*, andAddress; custom serde forSignatureandPublicKey(hex encoding); wraps raw[u8; 32]inHashtype and updates callerschainto consumeHashviaas_ref(); minor logging/hex fixes usinghash.0.gitignoreto ignore./data; addsserde_jsondependencyWritten by Cursor Bugbot for commit 94cfadf. Configure here.