Automatically trigger OIDC login if redirected - #1747
Open
gzm0 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Tobias Schlatter <schlatter.tobias@gmail.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Automatically trigger OIDC login if we got redirected. The redirect originates here:
frontend/src/router/index.js
Lines 1210 to 1212 in 82b6350
Addressed Issue
Fixes #530.
Additional Details
I have considered introducing a config option / feature flag for this, but decided against it.
I'd expect all users to want this behavior.
I have tested this locally, both that the auto-redirect works and that manually navigating to
/logindoes not trigger it.Checklist
I have updated the documentation accordinglyIMHO insufficiently significant of a change for the docs, but should be in release notes.