Repository navigation
Conversation
This allows to optionally start a postgres container alongside the apiserver. Required for testing v5 specific client functions. Signed-off-by: fabiante <7669818+fabiante@users.noreply.github.com>
With v5 there will be multiple ports. OUr tests must explicitly select the API port. Without this, this could randomly return the management port which we do not want. Signed-off-by: fabiante <7669818+fabiante@users.noreply.github.com>
As the code comment describes, this ensures the test setup is able to work with v5. Technically redundant once “real” API tests are added for v5 endpoints. Signed-off-by: fabiante <7669818+fabiante@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #62
This is the result of trying to add client functionality based on new v5 API endpoints.
I thought extending the test setup first makes sense, as it enables others to add v5 based client functionalities too.