Skip to content

Issue #1928 add utvd support - #1929

Open
JoerivanEngelen wants to merge 6 commits into
masterfrom
issue_#1928_add_UTVD_support
Open

JoerivanEngelen wants to merge 6 commits into
masterfrom
issue_#1928_add_UTVD_support

Conversation

@JoerivanEngelen

Copy link
Copy Markdown
Contributor

Fixes #1928

Description

This adds support for the UTVD advection scheme for which @Manangka (and others) put in a lot of effort. I expect this advection scheme to be the scheme of choice in many cases as the example results here look very promising.. I didn't add another example, but modified an existing example of an unstructured tranport to use this scheme as it should be the advection scheme of choice for most of these models.

Checklist

  • Links to correct issue
  • Update changelog, if changes affect users
  • PR title starts with Issue #nr, e.g. Issue #737
  • Unit tests were added
  • If feature added: Added/extended example
  • If feature added: Added feature to API documentation
  • If pixi.lock was changed: Ran pixi run generate-sbom and committed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃煛 Changes recommended

Add the missing package-fixture and transport-splitting coverage, and update the stale module overview.

1 open finding
What changed in this PR

Adds public MODFLOW 6 UTVD advection support for unstructured transport models.

Changes:

  • Adds and exports AdvectionUTVD.
  • Updates the circle transport example.
  • Adds tests, API documentation, and a changelog entry.
File Reviewed changes
imod/鈥媡ests/鈥媡est_mf6/鈥媡est_mf6_adv.py Adds UTVD rendering coverage.
imod/鈥媘f6/鈥媋dv.py Defines UTVD; module documentation and broader package/transport test coverage need updates.
imod/鈥媘f6/鈥媉_init__.py Exports AdvectionUTVD.
examples/鈥媘f6/鈥媍ircle_transport.py Uses UTVD for unstructured transport.
docs/鈥媋pi/鈥媘f6.rst Documents the new API.
docs/鈥媋pi/鈥媍hangelog.rst Records the feature.

馃 Review effort: Lite


Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.

Comment thread imod/mf6/adv.py
@sonarqubecloud

sonarqubecloud Bot commented Oct 8, 2026

Copy link
Copy Markdown

@LuukBlom LuukBlom left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Seems like no logic was added and this is pure doc updates + kernel support?

Make sure the examples on Teamcity are building correctly before merging. Not sure about how its setup so approving already.
Perhaps the latest kernel updates need to be in Teacmity or something?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] - Add UTVD support

3 participants