You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Fout als ipf's geen punten bevat binnen window #1859
Bij onderstaande fout is het onduidelijk wat precies fout gaat. Mogelijk bevat 1 van de ipf's alleen punten buiten het window. Kon alleen worden opgelost door alle ipf's uit prj file te verwijderen.
The problem lies in the utility function imod.mf6.wel.mask_2D.
This is not properly unittested: The method is supposed to mask wells that are outside the exterior. So points_values should get an ignore. I don't understand why we are calling points_values, then do a boolean selection with it. It is probably better to straightaway call points_indices.
I just looked at this again with @rleander73 and I was wrong in the second half of my comment. The behavior of mask_2D is correct: A masking operation should not remove wells if they are out of bounds, instead throw an error. We have a clipping method for that. iMOD Python does the right thing here. Instead, the conversion script should be modified: First clip wells (by calling their cleanup method), then masking.
Just talked with @FransRoelofsen : A smaller river grid will be aligned during the import from imod5 to one target grid. In this operation, we could clip wells and HFBs as well, to better align these with the target grid.
Activity
JoerivanEngelen commentedon Jun 18, 2026
Duplicate of #1863
The problem lies in the utility function imod.mf6.wel.mask_2D.
This is not properly unittested: The method is supposed to mask wells that are outside the exterior. So
points_valuesshould get anignore. I don't understand why we are callingpoints_values, then do a boolean selection with it. It is probably better to straightaway callpoints_indices.JoerivanEngelen commentedon Jun 18, 2026
I just looked at this again with @rleander73 and I was wrong in the second half of my comment. The behavior of
mask_2Dis correct: A masking operation should not remove wells if they are out of bounds, instead throw an error. We have a clipping method for that. iMOD Python does the right thing here. Instead, the conversion script should be modified: First clip wells (by calling their cleanup method), then masking.JoerivanEngelen commentedon Jul 13, 2026
Just talked with @FransRoelofsen : A smaller river grid will be aligned during the import from imod5 to one target grid. In this operation, we could clip wells and HFBs as well, to better align these with the target grid.
JoerivanEngelen commentedon Sep 14, 2026
Fixed downstream in: Deltares/iMOD-Suite-transition-regional-models#22