Skip to content

Fout als ipf's geen punten bevat binnen window #1859

Closed
Deltares/iMOD-Suite-transition-regional-models
#22

Description

@jc-hunink

Bij onderstaande fout is het onduidelijk wat precies fout gaat. Mogelijk bevat 1 van de ipf's alleen punten buiten het window. Kon alleen worden opgelost door alle ipf's uit prj file te verwijderen.

Image

Activity

  1. JoerivanEngelen commented on Jun 18, 2026

    @JoerivanEngelen
    Contributor

    Duplicate of #1863

    The problem lies in the utility function imod.mf6.wel.mask_2D.

    This is not properly unittested: The method is supposed to mask wells that are outside the exterior. So points_values should get an ignore. I don't understand why we are calling points_values, then do a boolean selection with it. It is probably better to straightaway call points_indices.

  2. moved this from 📯 New to 📝Refined in iMOD Suiteon Jun 18, 2026
  3. JoerivanEngelen commented on Jun 18, 2026

    @JoerivanEngelen
    Contributor

    I just looked at this again with @rleander73 and I was wrong in the second half of my comment. The behavior of mask_2D is correct: A masking operation should not remove wells if they are out of bounds, instead throw an error. We have a clipping method for that. iMOD Python does the right thing here. Instead, the conversion script should be modified: First clip wells (by calling their cleanup method), then masking.

  4. JoerivanEngelen commented on Jul 13, 2026

    @JoerivanEngelen
    Contributor

    Just talked with @FransRoelofsen : A smaller river grid will be aligned during the import from imod5 to one target grid. In this operation, we could clip wells and HFBs as well, to better align these with the target grid.

  5. self-assigned this
    on Aug 31, 2026
  6. moved this from 📝Refined to ✅ Done in iMOD Suiteon Sep 14, 2026
  7. JoerivanEngelen commented on Sep 14, 2026

    @JoerivanEngelen
    Contributor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

backwards_compatibilityBackwards compatibility with iMOD5bugSomething isn't working

Type

No type

Projects

Relationships

None yet

Development

No branches or pull requests

Issue actions