pcap: 60s active / 15s inactive timeouts (0.4.0) - #4
Merged
Conversation
Align flowprep pcap aggregation with common NetFlow exporter practice, expose integer-second CLI overrides, and document the breaking default change for 0.4.0. Co-authored-by: Cursor <cursoragent@cursor.com>
samarmstrong
approved these changes
Aug 12, 2026
samarmstrong
left a comment
samarmstrong
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. Timeout split semantics, CLI validation, tests, and the 0.4.0 bump look correct. Dropped CONTEXT.md and the ADR so they do not land in the OSS tree; README CLI notes stay so public docs match the new defaults.
Keep the README CLI notes so public docs match the 0.4.0 timeout defaults. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--active-timeout/--inactive-timeoutCLI overrides.> 0, inactive<=active); keep strict>split semantics; bump to 0.4.0.CONTEXT.md), ADR0001, unit tests for both split axes, and README updates.Test plan
cargo test --locked(53 tests, including new pcap timeout tests)cargo clippy --all-targets -- -D warningscargo fmt --all -- --checkflowprep pcap sample.pcap out.parquetand with explicit timeout flags