Fix hccl-shim deadlock and expand Msprof passthrough exports - #77
Merged
reiase merged 2 commits intoJul 27, 2026
Merged
Conversation
Replace the reentrant Mutex around real libprofapi with OnceCell so HCCL/MSProf callbacks cannot hang, and forward the additional Msprof/prof* symbols Ascend needs when the shim is first on LD_LIBRARY_PATH. Co-authored-by: Cursor <cursoragent@cursor.com>
- rustfmt hccl-shim forward.rs / lib.rs (wrap long fn-pointer types). - hccl-shim names.rs: use ptr::cast to avoid unnecessary_cast on aarch64. - cli aarch64 inject: from_mut for ref_as_ptr, add digit separators to hex literals. - aarch64 inject regression test: wait() the spawned child (zombie_processes).
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parking_lot::Mutexaround reallibprofapiloading withOnceCell, avoiding deadlock when HCCL/MSProf callbacks re-enter the shim's exportedMsprof*symbols (previously hung ataclprofStart).Msprof*/prof*symbols so Ascend runtime can resolvelibprofapiwhen the shim is first onLD_LIBRARY_PATH.Test plan
make hccl-shim-libPROBING_HCCL_PROFAPI_REAL, put shim dir first onLD_LIBRARY_PATHacl.profpath and confirmaclprofStartno longer hangshccl.*tablesMade with Cursor